From: Borislav Petkov <bp@alien8.de>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Qian Cai <cai@lca.pw>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/cacheinfo: fix a -Wtype-limits warning
Date: Wed, 19 Jun 2019 19:18:42 +0200 [thread overview]
Message-ID: <20190619171842.GG9574@zn.tnic> (raw)
In-Reply-To: <20190619171249.GG1203@linux.intel.com>
On Wed, Jun 19, 2019 at 10:12:49AM -0700, Sean Christopherson wrote:
> Ha, no. My comment was that it'd be worth explaining that the original
> 'c->x86_model >= 0' check was completely bogus, even if the intent was
> something like 'c->x86_model != 0'.
Nah, the intent was, I believe, to convert a model range into a
conditional. If ->x86_model is not set we have bigger problems.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
prev parent reply other threads:[~2019-06-19 17:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 19:40 [PATCH] x86/cacheinfo: fix a -Wtype-limits warning Qian Cai
2019-06-05 20:07 ` Sean Christopherson
2019-06-19 17:01 ` Borislav Petkov
2019-06-19 17:12 ` Sean Christopherson
2019-06-19 17:18 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619171842.GG9574@zn.tnic \
--to=bp@alien8.de \
--cc=cai@lca.pw \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox