From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34458C48BE0 for ; Fri, 21 Jun 2019 09:13:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04B11208C3 for ; Fri, 21 Jun 2019 09:13:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="cVvcQJ3u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbfFUJNy (ORCPT ); Fri, 21 Jun 2019 05:13:54 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:40936 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726250AbfFUJNy (ORCPT ); Fri, 21 Jun 2019 05:13:54 -0400 Received: by mail-ed1-f66.google.com with SMTP id k8so9075382eds.7 for ; Fri, 21 Jun 2019 02:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=2bGIaORqqfh7NthvfPKeSWzPcbNzBBYxFsaIjbRgqzI=; b=cVvcQJ3ufJ+1Qqgqq4fWCNNUQ+RUopn+7hW8VyzYhB/jgWEmSBwXkOA93mdNxl3+4x zec6W4/WvUs2j9kiT0afQFuRDsf2jTsrbeZ/NhVF42PG33pIHNkX5BLj1IoYDgn31T0W iD8ZlugNc30sg2bDloI5XgFiyGiO1MB3lbZrE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=2bGIaORqqfh7NthvfPKeSWzPcbNzBBYxFsaIjbRgqzI=; b=F12iNRaIup+BcYFSSLPyqdBc01K+DUhfNhdix6Jvgeh9NlfD0NWpL/sBo+b8E6mKgr FjDvQGWJe3AldF6gEL5ar+kXDKvxOdzMfp6UWhJWCKWwI2DqJP/13QPgcWStzakfDend ZOoCGiVfpAr623wdOEYcSuCckPfBWxJGuDwC475ZHRMH/lqxgaUbSNRsSnY/mH4TVzkb Vft2yCRoQoczGSQ+9SY+WCgrY2SIsXu165W2IzO7XQqMI9x6csKbKfHz5aynSYY7NroJ 3sUBEMlliXWx6Dt9wbZzEVNcbHVkB/8d6/HoHsdyNJEWCV6J7HDySz3G/A2cAwcV/Inj UrbQ== X-Gm-Message-State: APjAAAXGIjaduuh73wpTj5SK3p3u47vI3lqU/bh4LyLKpJnIDZCnLS0o Sl+t+/26UTZ+NOUyL871C6IxYw== X-Google-Smtp-Source: APXvYqw14PDnEzjHiPPTDgNf/p3y3XKQE24CKUmI/tC7fQOPfvWanfqpuXk6IlS1WmRPiRcr2v9GQA== X-Received: by 2002:aa7:c619:: with SMTP id h25mr82941231edq.295.1561108431657; Fri, 21 Jun 2019 02:13:51 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id p18sm327962ejr.61.2019.06.21.02.13.49 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 21 Jun 2019 02:13:50 -0700 (PDT) Date: Fri, 21 Jun 2019 11:13:43 +0200 From: Daniel Vetter To: Paul Cercueil Cc: Daniel Vetter , Sam Ravnborg , David Airlie , Rob Herring , Mark Rutland , Maarten Lankhorst , Maxime Ripard , Sean Paul , od@zcrc.me, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Artur Rojek Subject: Re: [PATCH v5 2/2] DRM: Add KMS driver for the Ingenic JZ47xx SoCs Message-ID: <20190621091343.GA12905@phenom.ffwll.local> Mail-Followup-To: Paul Cercueil , Sam Ravnborg , David Airlie , Rob Herring , Mark Rutland , Maarten Lankhorst , Maxime Ripard , Sean Paul , od@zcrc.me, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Artur Rojek References: <20190603152331.23160-1-paul@crapouillou.net> <20190603152331.23160-2-paul@crapouillou.net> <20190619122622.GB29084@ravnborg.org> <1561040159.1978.0@crapouillou.net> <20190621090411.GY12905@phenom.ffwll.local> <1561108050.1777.0@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1561108050.1777.0@crapouillou.net> X-Operating-System: Linux phenom 4.19.0-5-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 21, 2019 at 11:07:30AM +0200, Paul Cercueil wrote: > > > Le ven. 21 juin 2019 à 11:04, Daniel Vetter a écrit : > > On Thu, Jun 20, 2019 at 04:15:59PM +0200, Paul Cercueil wrote: > > > > > > > > > Le mer. 19 juin 2019 à 14:26, Sam Ravnborg a > > > écrit : > > > > Hi Paul. > > > > > > > > On Mon, Jun 03, 2019 at 05:23:31PM +0200, Paul Cercueil wrote: > > > > > Add a KMS driver for the Ingenic JZ47xx family of SoCs. > > > > > This driver is meant to replace the aging jz4740-fb driver. > > > > > > > > > > This driver does not make use of the simple pipe helper, for > > > the > > > > > reason > > > > > that it will soon be updated to support more advanced features > > > like > > > > > multiple planes, IPU integration for colorspace conversion and > > > > > up/down > > > > > scaling, support for DSI displays, and TV-out and HDMI outputs. > > > > > > > > > > Signed-off-by: Paul Cercueil > > > > > Tested-by: Artur Rojek > > > > > --- > > > > > > > > > > Notes: > > > > > v2: - Remove custom handling of panel. The panel is now > > > > > discovered using > > > > > the standard API. > > > > > - Lots of small tweaks suggested by upstream > > > > > > > > > > v3: - Use devm_drm_dev_init() > > > > > - Update compatible strings to -lcd instead of -drm > > > > > - Add destroy() callbacks to plane and crtc > > > > > - The ingenic,lcd-mode is now read from the bridge's DT > > > node > > > > > > > > > > v4: Remove ingenic,lcd-mode property completely. The > > > various > > > > > modes are now > > > > > deduced from the connector type, the pixel format or the > > > bus > > > > > flags. > > > > > > > > > > v5: - Fix framebuffer size incorrectly calculated for 24bpp > > > > > framebuffers > > > > > - Use 32bpp framebuffer instead of 16bpp, as it'll work > > > with > > > > > both > > > > > 16-bit and 24-bit panel > > > > > - Get rid of drm_format_plane_cpp() which has been dropped > > > > > upstream > > > > > - Avoid using drm_format_info->depth, which is deprecated. > > > > In the drm world we include the revision notes in the changelog. > > > > So I did this when I applied it to drm-misc-next. > > > > > > > > Fixed a few trivial checkpatch warnings about indent too. > > > > There was a few too-long-lines warnings that I ignored. Fixing > > > them > > > > would have hurt readability. > > > > > > Thanks. > > > > > > > I assume you will maintain this driver onwards from now. > > > > Please request drm-misc commit rights (see > > > > https://www.freedesktop.org/wiki/AccountRequests/) > > > > You will need a legacy SSH account. > > > > > > I requested an account here: > > > https://gitlab.freedesktop.org/freedesktop/freedesktop/issues/162 > > > > This 404s for me. Did you set the issue to private by any chance? Or > > deleted already again? > > -Daniel > > Sorry, yes, I set it to private. I thought I had to :( Well I can't ack it if its private, so please change that. Also, everything is public around here, or almost everything ... -Daniel > > -Paul > > > > > > > > > And you should familiarize yourself with the maintainer-tools: > > > > https://drm.pages.freedesktop.org/maintainer-tools/index.html > > > > > > > > For my use I use "dim update-branches; dim apply; dim push > > > > So only a small subset i needed for simple use. > > > > > > > > Sam > > > > > > > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch