Re: [RFC PATCH v4 03/21] x86/hpet: Calculate ticks-per-second in a separate function

Thomas Gleixner
2019-06-18T23:14:12Z

On Tue, 18 Jun 2019, Ricardo Neri wrote:
> On Fri, Jun 14, 2019 at 05:54:05PM +0200, Thomas Gleixner wrote:
> >
> > So we already have ticks per second, aka frequency, right? So why do we
> > need yet another function instead of using the value which is computed
> > once? The frequency of the HPET channels has to be identical no matter
> > what. If it's not HPET is broken beyond repair.
>
> I don't think it needs to be recomputed again. I missed the fact that
> the frequency was already computed here.
>
> Also, the hpet char driver has its own frequency computation. Perhaps it
> could also obtain it from here, right?

No. It's separate on purpose. Hint: IA64, aka Itanic

Thanks,

tglx