From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0468DC48BE3 for ; Fri, 21 Jun 2019 16:44:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9AB320665 for ; Fri, 21 Jun 2019 16:44:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561135473; bh=m33EIjjXIG8VQjpoiuplC1PQdv27MnbGyWxYvzJb5iU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=DeB6GU8uvDawvKq+rH8Hd0LJSGeRPLTHZ99sC9Lasgrzs49QG5JbyyII6U7PfSl6x krjtNDuXkwFg9StgqLf5655+lKdN0LAKivSxuJPHdZlzXgiRp7GUx0rndQ9jxh/Qj4 VYUBKtlkECN7xWUVg0mBbYZOjYtRuvQ0+/jMNB7s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726134AbfFUQoc (ORCPT ); Fri, 21 Jun 2019 12:44:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:34422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725985AbfFUQoc (ORCPT ); Fri, 21 Jun 2019 12:44:32 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2599920665; Fri, 21 Jun 2019 16:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561135471; bh=m33EIjjXIG8VQjpoiuplC1PQdv27MnbGyWxYvzJb5iU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=edhSQJnoaE2M7HPSpl01zi1vEtEhmwOmlCV0ykFpyZQG5VE2zNsgNeeX9l26kpK/O ZO8r1GMrygTMMQ4BoZ/jXGQeC0bZQ+63UD5uJNe9J19Ud7q20fKYRhuSgrnbV8YnYr qZhG27ydBquwpLnQgwXYJGdiDokvJ4YE5w5SAe+0= Date: Fri, 21 Jun 2019 11:44:29 -0500 From: Bjorn Helgaas To: Alan Cox Cc: Puranjay Mohan , Shuah Khan , Bjorn Helgaas , netdev , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates Message-ID: <20190621164429.GA187016@google.com> References: <20190621094607.15011-1-puranjay12@gmail.com> <20190621162024.53620dd9@alans-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190621162024.53620dd9@alans-desktop> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 21, 2019 at 04:20:24PM +0100, Alan Cox wrote: > On Fri, 21 Jun 2019 15:16:04 +0530 > Puranjay Mohan wrote: > > > This patch series removes the private duplicates of PCI definitions in > > favour of generic definitions defined in pci_regs.h. > > Why bother ? It's an ancient obsolete card ? That's a fair question. Is there anything that would indicate that "this file is obsolete and problems shouldn't be fixed"? Nobody wants to waste time on things that don't need to be fixed, but I don't know how to tell if something is obsolete. My naive assumption is that if something is in the tree, it's fair game for fixes and cleanups. Bjorn