From: Harshavardhan Unnibhavi <hvubfoss@gmail.com>
To: skhan@linuxfoundation.org
Cc: Harshavardhan Unnibhavi <hvubfoss@gmail.com>,
mchehab@kernel.org, gregkh@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] staging: soc_mt9v022: replace symbolic permission with octal permission
Date: Fri, 21 Jun 2019 22:14:53 +0530 [thread overview]
Message-ID: <20190621164453.5075-1-hvubfoss@gmail.com> (raw)
Resolved following checkpatch issue:
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
using octal permissions '0444'.
Signed-off-by: Harshavardhan Unnibhavi <hvubfoss@gmail.com>
---
drivers/staging/media/soc_camera/soc_mt9v022.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/soc_camera/soc_mt9v022.c b/drivers/staging/media/soc_camera/soc_mt9v022.c
index e7e0d3d29499..f73f5460663c 100644
--- a/drivers/staging/media/soc_camera/soc_mt9v022.c
+++ b/drivers/staging/media/soc_camera/soc_mt9v022.c
@@ -25,7 +25,7 @@
*/
static char *sensor_type;
-module_param(sensor_type, charp, S_IRUGO);
+module_param(sensor_type, charp, 0444);
MODULE_PARM_DESC(sensor_type, "Sensor type: \"colour\" or \"monochrome\"");
/* mt9v022 selected register addresses */
--
2.17.1
reply other threads:[~2019-06-21 16:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621164453.5075-1-hvubfoss@gmail.com \
--to=hvubfoss@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox