* [PATCH] staging: soc_mt9v022: replace symbolic permission with octal permission
@ 2019-06-21 16:44 Harshavardhan Unnibhavi
0 siblings, 0 replies; only message in thread
From: Harshavardhan Unnibhavi @ 2019-06-21 16:44 UTC (permalink / raw)
To: skhan
Cc: Harshavardhan Unnibhavi, mchehab, gregkh, linux-kernel-mentees,
linux-kernel
Resolved following checkpatch issue:
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
using octal permissions '0444'.
Signed-off-by: Harshavardhan Unnibhavi <hvubfoss@gmail.com>
---
drivers/staging/media/soc_camera/soc_mt9v022.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/soc_camera/soc_mt9v022.c b/drivers/staging/media/soc_camera/soc_mt9v022.c
index e7e0d3d29499..f73f5460663c 100644
--- a/drivers/staging/media/soc_camera/soc_mt9v022.c
+++ b/drivers/staging/media/soc_camera/soc_mt9v022.c
@@ -25,7 +25,7 @@
*/
static char *sensor_type;
-module_param(sensor_type, charp, S_IRUGO);
+module_param(sensor_type, charp, 0444);
MODULE_PARM_DESC(sensor_type, "Sensor type: \"colour\" or \"monochrome\"");
/* mt9v022 selected register addresses */
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-06-21 16:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-21 16:44 [PATCH] staging: soc_mt9v022: replace symbolic permission with octal permission Harshavardhan Unnibhavi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox