From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FAFDC43613 for ; Fri, 21 Jun 2019 21:17:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C65D208C3 for ; Fri, 21 Jun 2019 21:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561151835; bh=qu9zhz0VbubD/aIMmtVALLqw4rls2icALX3kK1BJ398=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=gp1ADrjtThk4dShI0sBkyS2rmIjfdxaWGvw2yP6AxA66ZIHvb/4rfj9Hr3KX+0K0b B2G36+hhQNhIoFLMVpherkVUJnV3sjVjM2YSTZh3YqGt2l1QxkuCA7JpezqTOyCbet fC/vZhsoWIQPgzhwwZKLj+k64WBYVGsAtnro8OhI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726276AbfFUVRN (ORCPT ); Fri, 21 Jun 2019 17:17:13 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:34422 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbfFUVRN (ORCPT ); Fri, 21 Jun 2019 17:17:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qu9zhz0VbubD/aIMmtVALLqw4rls2icALX3kK1BJ398=; b=CbxbvGaDW/SGjuYT4KQh+32Is xpEmBHgzuKDh/qAxROQUjrKjjT9w3CxRffdXdDW0YzOEux4EeSam+Qv0k5p3Zq9TvO7sxu4PQZZKy zZZ7u5slvmEXS8y3gF39SEEc2+jDTzDmj0PwCs87UVbLb5xdfNUnjDQFvhJei+lbvyJrMNa89akji LrE5fwnfDBaSBCu75KLqcurpU4nWp4HMEl+IiEdPhhaw4TuDHpCE7pU67jYxRLcqkQV7eEb8tvdFu 4B37eiy4LroTrFKc3jXDmBaZFP+aA+EM6P578AVObB0N7QZfLhDHXqz7ZPpXbSMCMjo0hkehNzXEq V7CyY7Fvg==; Received: from [177.97.20.138] (helo=coco.lan) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1heQuE-0000UU-EY; Fri, 21 Jun 2019 21:17:11 +0000 Date: Fri, 21 Jun 2019 18:17:05 -0300 From: Mauro Carvalho Chehab To: =?UTF-8?B?QW5kcsOp?= Almeida Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl, helen.koike@collabora.com, kernel@collabora.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] media: vimc: stream: add missing function documentation Message-ID: <20190621181705.44415597@coco.lan> In-Reply-To: <20190617133221.21246-1-andrealmeid@collabora.com> References: <20190617133221.21246-1-andrealmeid@collabora.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, 17 Jun 2019 10:32:20 -0300 Andr=C3=A9 Almeida escreveu: > Add comments at vimc_streamer_s_stream and vimc_streamer_thread, making > the vimc-stream totally documented. I'm applying it right now. Yet, if this is fully documented, IMO you should add it to Documentation/media/v4l-drivers, replacing the comments to kernel-doc markups. That would make easier for the ones to read the comments and, if someone changes a function call, warnings will be produced, and the developer will be warned. Thanks, Mauro