public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Pierre-Loup A. Griffais" <pgriffais@valvesoftware.com>,
	Eric Dumazet <edumazet@google.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: Steam is broken on new kernels
Date: Sat, 22 Jun 2019 09:37:53 +0200	[thread overview]
Message-ID: <20190622073753.GA10516@kroah.com> (raw)
In-Reply-To: <CAHk-=wjZ1grLwJsGD+Fjz1_U_W47AFodBiwBX84HECUHt-guuw@mail.gmail.com>

On Fri, Jun 21, 2019 at 10:28:21PM -0700, Linus Torvalds wrote:
> On Fri, Jun 21, 2019 at 6:03 PM Pierre-Loup A. Griffais
> <pgriffais@valvesoftware.com> wrote:
> >
> > I applied Eric's path to the tip of the branch and ran that kernel and
> > the bug didn't occur through several logout / login cycles, so things
> > look good at first glance. I'll keep running that kernel and report back
> > if anything crops up in the future, but I believe we're good, beyond
> > getting distros to ship this additional fix.
> 
> Good. It's now in my tree, so we can get it quickly into stable and
> then quickly to distributions.
> 
> Greg, it's commit b6653b3629e5 ("tcp: refine memory limit test in
> tcp_fragment()"), and I'm building it right now and I'll push it out
> in a couple of minutes assuming nothing odd is going on.

This looks good for 4.19 and 5.1, so I'll push out new stable kernels in
a bit for them.

But for 4.14 and older, we don't have the "hint" to know this is an
outbound going packet and not to apply these checks at that point in
time, so this patch doesn't work.

I'll see if I can figure anything else later this afternoon for those
kernels...

thanks,

greg k-h

  parent reply	other threads:[~2019-06-22  7:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21 21:27 Steam is broken on new kernels Pierre-Loup A. Griffais
2019-06-21 21:41 ` Greg Kroah-Hartman
2019-06-21 21:43   ` Pierre-Loup A. Griffais
2019-06-21 22:19   ` Linus Torvalds
     [not found]     ` <CANn89iL5+x3n9H9v4O6y39W=jvQs=uuXbzOvN5mBbcj0t+wdeg@mail.gmail.com>
2019-06-21 23:04       ` Pierre-Loup A. Griffais
2019-06-21 23:42         ` Josh Hunt
2019-06-21 23:54       ` Linus Torvalds
2019-06-22  0:19         ` Eric Dumazet
2019-06-22  1:01           ` Pierre-Loup A. Griffais
2019-06-22  5:28             ` Linus Torvalds
2019-06-22  6:35               ` Greg Kroah-Hartman
2019-06-22  7:37               ` Greg Kroah-Hartman [this message]
2019-06-26  2:02                 ` Guenter Roeck
2019-06-26  2:29                   ` Greg Kroah-Hartman
2019-06-26  3:43                     ` Guenter Roeck
2019-06-26  4:20                       ` Eric Dumazet
2019-06-26  5:17                         ` Greg Kroah-Hartman
2019-06-26  6:38                           ` Eric Dumazet
2019-06-26  8:23                             ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190622073753.GA10516@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=edumazet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pgriffais@valvesoftware.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox