From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86228C48BE8 for ; Sat, 22 Jun 2019 09:21:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B2852070B for ; Sat, 22 Jun 2019 09:21:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561195286; bh=wkdTMticKHUz+cqAK4HXYfHz22t3/vjmhA1xKNHdB30=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=NBHxSeQSptoZVEPN59rfEBf0xZknbb+RosbfOLd0Pk0EzcqYGUNgvjlUzcuVz7WgF TOZgC/tlBRHtm3gTy3v1FWUgRa5L1V5J8J6kf6HkcDPckxBt0vG5Urpbv9H6Isx7ur eKigHav56yDH9ws46GVNrjCr7j7OKxvhiGxbYQkU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726334AbfFVJVZ (ORCPT ); Sat, 22 Jun 2019 05:21:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:58510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726187AbfFVJVY (ORCPT ); Sat, 22 Jun 2019 05:21:24 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F86E205F4; Sat, 22 Jun 2019 09:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561195283; bh=wkdTMticKHUz+cqAK4HXYfHz22t3/vjmhA1xKNHdB30=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2b1Fs1wv3cLZcM3ddy5Imq5aX1oUyn4BskTADmRj3/zN0VqBAh8p4ZDaOdh4oivQ6 Ef9+oE8oBzYGvMBa40/aB4e/iqxJ2ICfzNyPVnKuBxjc2YiNqy9uNgf5FH9Y1Oxd7P EytmmecSLYh0JNtWxL5ybfYBrpICRGVvz0MMTeoI= Date: Sat, 22 Jun 2019 10:21:17 +0100 From: Jonathan Cameron To: Olivier Moysan Cc: , , , , , , , , , , Subject: Re: [PATCH 2/5] iio: adc: stm32-dfsdm: fix data type Message-ID: <20190622102117.5289e1e2@archlinux> In-Reply-To: <1560949431-22948-3-git-send-email-olivier.moysan@st.com> References: <1560949431-22948-1-git-send-email-olivier.moysan@st.com> <1560949431-22948-3-git-send-email-olivier.moysan@st.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Jun 2019 15:03:48 +0200 Olivier Moysan wrote: > Fix the data type as DFSDM raw output is complements 2, > 24bits left aligned in a 32-bit register. > This change does not affect AUDIO path > - Set data as signed for IIO (as for AUDIO) > - Set 8 bit right shift for IIO. > The 8 LSBs bits of data contains channel info and are masked. > > Fixes: e2e6771c6462 ("IIO: ADC: add STM32 DFSDM sigma delta ADC support") > > Signed-off-by: Olivier Moysan Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with them. Thanks, Jonathan > --- > drivers/iio/adc/stm32-dfsdm-adc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > index cb596f104919..6b90a40882f2 100644 > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > @@ -1365,11 +1365,11 @@ static int stm32_dfsdm_adc_chan_init_one(struct iio_dev *indio_dev, > BIT(IIO_CHAN_INFO_SAMP_FREQ); > > if (adc->dev_data->type == DFSDM_AUDIO) { > - ch->scan_type.sign = 's'; > ch->ext_info = dfsdm_adc_audio_ext_info; > } else { > - ch->scan_type.sign = 'u'; > + ch->scan_type.shift = 8; > } > + ch->scan_type.sign = 's'; > ch->scan_type.realbits = 24; > ch->scan_type.storagebits = 32; >