From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E869C48BE8 for ; Sat, 22 Jun 2019 09:33:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 243DD2089C for ; Sat, 22 Jun 2019 09:33:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561195996; bh=I0NwKMdM7grA72wdghATYuLC9S2scyeIRrURUSdnpWc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=SBGld+dOJWUrjdVr5VX/QyP2ljj7TJClS/UkGQ2GMKAMxGwdpnQzk4yViXtQjBhST yX+NnRERwruXh8FMRmippZtuTAY95d3IQTXXbZYgUbvr2oOgOTCeApQ1NJ6aIlAXyu Wh2NCYVxBMPbbZnFOYAjn28GcTtXrQYYY6Y9p6S8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726372AbfFVJdO (ORCPT ); Sat, 22 Jun 2019 05:33:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:46350 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726187AbfFVJdO (ORCPT ); Sat, 22 Jun 2019 05:33:14 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1FF7B2075E; Sat, 22 Jun 2019 09:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561195993; bh=I0NwKMdM7grA72wdghATYuLC9S2scyeIRrURUSdnpWc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fjYvZv6SCiSgFIbOvVkdSfPQMb3qP+hXn19RP8kVFsA+lDN0AXzmkMQhD7MlJOTjg ZkYP+qzVkxjnbrhWrqB/kjGwGGIn/h/kadTwkoc2V+ouCWMCHhhbEr73mbQ7KKrY1a yWlr8ul5/WMbgUn74wcqKyiNNfBqiaCvoi1GYyJc= Date: Sat, 22 Jun 2019 10:33:07 +0100 From: Jonathan Cameron To: Olivier Moysan Cc: , , , , , , , , , , Subject: Re: [PATCH 5/5] iio: adc: stm32-dfsdm: add comment for 16 bits record Message-ID: <20190622103307.50ba052b@archlinux> In-Reply-To: <1560949431-22948-6-git-send-email-olivier.moysan@st.com> References: <1560949431-22948-1-git-send-email-olivier.moysan@st.com> <1560949431-22948-6-git-send-email-olivier.moysan@st.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Jun 2019 15:03:51 +0200 Olivier Moysan wrote: > Add a comment on DMA configuration for 16 bits record. > > Signed-off-by: Olivier Moysan Applied. Thanks, Jonathan > --- > drivers/iio/adc/stm32-dfsdm-adc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > index d855a605eab6..ee1e0569d0e1 100644 > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > @@ -918,6 +918,11 @@ static void stm32_dfsdm_dma_buffer_done(void *data) > static int stm32_dfsdm_adc_dma_start(struct iio_dev *indio_dev) > { > struct stm32_dfsdm_adc *adc = iio_priv(indio_dev); > + /* > + * The DFSDM supports half-word transfers. However, for 16 bits record, > + * 4 bytes buswidth is kept, to avoid losing samples LSBs when left > + * shift is required. > + */ > struct dma_slave_config config = { > .src_addr = (dma_addr_t)adc->dfsdm->phys_base, > .src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES,