From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: "André Almeida" <andrealmeid@collabora.com>
Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl,
helen.koike@collabora.com, kernel@collabora.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] media: vimc: stream: format comments as kernel-doc
Date: Mon, 24 Jun 2019 06:40:04 -0300 [thread overview]
Message-ID: <20190624064004.224cccfb@coco.lan> (raw)
In-Reply-To: <a1973442-5ccb-5ba3-e508-132514b6e83e@collabora.com>
Em Sun, 23 Jun 2019 18:27:22 -0300
André Almeida <andrealmeid@collabora.com> escreveu:
> On 6/23/19 1:40 PM, André Almeida wrote:
> > - * Calls s_stream to enable stream in all entities of the pipeline.
> > + * Calls ``vimc_streamer_s_stream`` to enable stream in all entities of
> ``vimc_streamer_s_stream`` could also been written as
> :c:func:`vimc_streamer_s_stream`. In this latest setup, the
> Documentation output would display a nice hyperlink to the documentation
> of vimc_streamer_s_stream function. Is this a good improvement or it
> will be too verbose?
The best would be to use: vimc_streamer_s_stream(). Kernel-doc already
handles it (don't remember if it uses :c:func:, but I guess it does),
and this is the recommended way.
Anyway, there's a patch under discussion right now at Linux docs ML that
will auto-replace these to :c:func`` automatically, not only on kernel-doc
tags, but also within the .rst files. It should be able to recognize
existing :c:func: tags, so no harm done if it is there somewhere.
Thanks,
Mauro
next prev parent reply other threads:[~2019-06-24 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 16:40 [PATCH 1/5] media: vimc: stream: remove obsolete function doc André Almeida
2019-06-23 16:40 ` [PATCH 2/5] media: vimc: stream: fix style of argument description André Almeida
2019-06-23 16:40 ` [PATCH 3/5] media: vimc: stream: format comments as kernel-doc André Almeida
2019-06-23 21:27 ` André Almeida
2019-06-24 9:40 ` Mauro Carvalho Chehab [this message]
2019-06-24 12:26 ` André Almeida
2019-06-23 16:40 ` [PATCH 4/5] media: vimc.rst: Add a proper alt attribute to vimc.dot André Almeida
2019-06-23 16:40 ` [PATCH 5/5] media: vimc.rst: add vimc-streamer source documentation André Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624064004.224cccfb@coco.lan \
--to=mchehab+samsung@kernel.org \
--cc=andrealmeid@collabora.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox