From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A4CFC48BE8 for ; Mon, 24 Jun 2019 16:24:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2BE3205C9 for ; Mon, 24 Jun 2019 16:24:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="D2uGrxuE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729999AbfFXQYm (ORCPT ); Mon, 24 Jun 2019 12:24:42 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:54368 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728531AbfFXQYl (ORCPT ); Mon, 24 Jun 2019 12:24:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fbuOEGD6/p3KGLV+SsGx2RFhZqUs0c/4MZswvhidVf4=; b=D2uGrxuEdFzruVC29WTvIkFpCi bN7wchEmq/rvf1zT2YMyFEcF27QgmyFgbSsivPFALpo53XmgCKP0xOg5aL79oIMMZZJW+bXPWIN2q Z4a5M+Mh2wBSH/YuO3dWLF0f0wHNGqfTwjrejeyYIudJJWMuetxRZA9BNAr3M/brhG30=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hfRlf-0006oM-P5; Mon, 24 Jun 2019 18:24:31 +0200 Date: Mon, 24 Jun 2019 18:24:31 +0200 From: Andrew Lunn To: "Allan W. Nielsen" Cc: Alexandre Belloni , Claudiu Manoil , "David S . Miller" , "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , Alexandru Marginean , "linux-kernel@vger.kernel.org" , "UNGLinuxDriver@microchip.com" , Allan Nielsen , Rob Herring , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH net-next 4/6] arm64: dts: fsl: ls1028a: Add Felix switch port DT node Message-ID: <20190624162431.GX31306@lunn.ch> References: <1561131532-14860-1-git-send-email-claudiu.manoil@nxp.com> <1561131532-14860-5-git-send-email-claudiu.manoil@nxp.com> <20190621164940.GL31306@lunn.ch> <20190624115558.GA5690@piout.net> <20190624142625.GR31306@lunn.ch> <20190624152344.3bv46jjhhygo6zwl@lx-anielsen.microsemi.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190624152344.3bv46jjhhygo6zwl@lx-anielsen.microsemi.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 24, 2019 at 05:23:45PM +0200, Allan W. Nielsen wrote: > Hi Andrew, > > The 06/24/2019 16:26, Andrew Lunn wrote: > > > > Yeah, there are 2 ethernet controller ports (managed by the enetc driver) > > > > connected inside the SoC via SGMII links to 2 of the switch ports, one of > > > > these switch ports can be configured as CPU port (with follow-up patches). > > > > > > > > This configuration may look prettier on DSA, but the main restriction here > > > > is that the entire functionality is provided by the ocelot driver which is a > > > > switchdev driver. I don't think it would be a good idea to copy-paste code > > > > from ocelot to a separate dsa driver. > > > > > > > > > > We should probably make the ocelot driver a DSA driver then... > > An important part of DSA is being able to direct frames out specific > > ports when they ingress via the CPU port. Does the silicon support > > this? At the moment, i think it is using polled IO. > > That is supported, it requires a bit of initial configuration of the Chip, but > nothing big (I believe this configuration is part of Claudiu's change-set). > > But how do you envision this done? > > - Let the existing SwitchDev driver and the DSA driver use a set of common > functions. > - Convert the existing Ocelot driver from SwitchDev to DSA > - Fork (copy) the existing driver of Ocelot, and modify it as needed for the > Felix driver > > My guess is the first one, but I would like to understand what you have in mind. I don't know the various architectures the switch is used in. But it does seem like a core library, and then a switchdev wrapper for Ocelot and a DSA wrapper for Felix would make sense. Andrew