From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Andrew Morton <akpm@linux-foundation.org>,
Dave Airlie <airlied@linux.ie>,
DRI <dri-devel@lists.freedesktop.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Hellstrom <thellstrom@vmware.com>,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: linux-next: manual merge of the akpm-current tree with the drm tree
Date: Mon, 24 Jun 2019 20:49:08 +1000 [thread overview]
Message-ID: <20190624204908.64a33862@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 4066 bytes --]
Hi all,
Today's linux-next merge of the akpm-current tree got a conflict in:
mm/memory.c
between commit:
29875a52915e ("mm: Add an apply_to_pfn_range interface")
from the drm tree and commit:
e972cea08fb3 ("mm/pgtable: drop pgtable_t variable from pte_fn_t functions")
from the akpm-current tree.
I fixed it up (see below my signature, then added the following merge
resolution patch as well) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 24 Jun 2019 20:40:46 +1000
Subject: [PATCH] merge fixup for "mm: Add an apply_to_pfn_range interface"
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
include/linux/mm.h | 2 +-
mm/as_dirty_helpers.c | 8 ++------
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 87d53de3dee4..4404e18443ef 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2673,7 +2673,7 @@ extern int apply_to_page_range(struct mm_struct *mm, unsigned long address,
unsigned long size, pte_fn_t fn, void *data);
struct pfn_range_apply;
-typedef int (*pter_fn_t)(pte_t *pte, pgtable_t token, unsigned long addr,
+typedef int (*pter_fn_t)(pte_t *pte, unsigned long addr,
struct pfn_range_apply *closure);
struct pfn_range_apply {
struct mm_struct *mm;
diff --git a/mm/as_dirty_helpers.c b/mm/as_dirty_helpers.c
index f600e31534fb..7c863626c2a4 100644
--- a/mm/as_dirty_helpers.c
+++ b/mm/as_dirty_helpers.c
@@ -26,7 +26,6 @@ struct apply_as {
/**
* apply_pt_wrprotect - Leaf pte callback to write-protect a pte
* @pte: Pointer to the pte
- * @token: Page table token, see apply_to_pfn_range()
* @addr: The virtual page address
* @closure: Pointer to a struct pfn_range_apply embedded in a
* struct apply_as
@@ -36,8 +35,7 @@ struct apply_as {
*
* Return: Always zero.
*/
-static int apply_pt_wrprotect(pte_t *pte, pgtable_t token,
- unsigned long addr,
+static int apply_pt_wrprotect(pte_t *pte, unsigned long addr,
struct pfn_range_apply *closure)
{
struct apply_as *aas = container_of(closure, typeof(*aas), base);
@@ -78,7 +76,6 @@ struct apply_as_clean {
/**
* apply_pt_clean - Leaf pte callback to clean a pte
* @pte: Pointer to the pte
- * @token: Page table token, see apply_to_pfn_range()
* @addr: The virtual page address
* @closure: Pointer to a struct pfn_range_apply embedded in a
* struct apply_as_clean
@@ -91,8 +88,7 @@ struct apply_as_clean {
*
* Return: Always zero.
*/
-static int apply_pt_clean(pte_t *pte, pgtable_t token,
- unsigned long addr,
+static int apply_pt_clean(pte_t *pte, unsigned long addr,
struct pfn_range_apply *closure)
{
struct apply_as *aas = container_of(closure, typeof(*aas), base);
--
2.20.1
--
Cheers,
Stephen Rothwell
diff --cc mm/memory.c
index 462aa47f8878,f8a75528658a..e7e37fcbd687
--- a/mm/memory.c
+++ b/mm/memory.c
@@@ -2037,12 -2036,11 +2035,11 @@@ static int apply_to_pte_range(struct pf
{
pte_t *pte;
int err;
- pgtable_t token;
spinlock_t *uninitialized_var(ptl);
- pte = (mm == &init_mm) ?
+ pte = (closure->mm == &init_mm) ?
pte_alloc_kernel(pmd, addr) :
- pte_alloc_map_lock(mm, pmd, addr, &ptl);
+ pte_alloc_map_lock(closure->mm, pmd, addr, &ptl);
if (!pte)
return -ENOMEM;
@@@ -2050,10 -2048,8 +2047,8 @@@
arch_enter_lazy_mmu_mode();
- token = pmd_pgtable(*pmd);
-
do {
- err = closure->ptefn(pte++, token, addr, closure);
- err = fn(pte++, addr, data);
++ err = closure->ptefn(pte++, addr, closure);
if (err)
break;
} while (addr += PAGE_SIZE, addr != end);
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2019-06-24 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 10:49 Stephen Rothwell [this message]
2019-06-24 11:06 ` linux-next: manual merge of the akpm-current tree with the drm tree Stephen Rothwell
2019-07-09 0:06 ` Stephen Rothwell
2019-07-15 1:11 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2020-04-03 3:58 Stephen Rothwell
2017-11-02 7:32 Stephen Rothwell
2016-03-07 8:14 Stephen Rothwell
2016-01-04 7:45 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624204908.64a33862@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox