From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EB3BC48BD4 for ; Tue, 25 Jun 2019 03:53:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E02182085A for ; Tue, 25 Jun 2019 03:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561434821; bh=LiKh1y/cVsCqNr8ux7WO7aEmLV31ud+AQ1bb0n+nvNg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=UdFYa5hj7z3DlsgEo+MgMkuyaNE3PoJMi0lndUnHFTQ7GD44yEiHsdrBNumT6A5+H FZOGFIrF1v3pVQX9jsq6G3ujDu4V61auYEsregkxcQYWO9gdySS8IJLeozjOcJCuoj Xvte4Ckee2JINGiyOE+kEe3e1OsniTezCvi8kDMg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727162AbfFYDxj (ORCPT ); Mon, 24 Jun 2019 23:53:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:35768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726833AbfFYDxj (ORCPT ); Mon, 24 Jun 2019 23:53:39 -0400 Received: from localhost (unknown [116.226.249.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 993EB20863; Tue, 25 Jun 2019 03:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561434818; bh=LiKh1y/cVsCqNr8ux7WO7aEmLV31ud+AQ1bb0n+nvNg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zy0hx9p/4crxzYjV1lRLmNA6srJEKNhjem7iURpTiZ6qZyykyJc4xvBjgFbuwsPBI LqUfYd9yJiH2pbvvMsA9I0JwKIbT8dhPcmzYkOFmPoWMn7kF9t4f7XcbUxpiVYvfOZ 70aqqAWKidJgfsmOQAnggYhLnpqxyh1bIcGdE/QQ= Date: Tue, 25 Jun 2019 11:08:07 +0800 From: Greg KH To: liaoweixiong Cc: Miquel Raynal , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Vignesh Raghavendra , Boris Brezillon , Frieder Schrempf , Peter Pan , Chuanhong Guo , Schrempf Frieder , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips Message-ID: <20190625030807.GA11074@kroah.com> References: <1561424549-784-1-git-send-email-liaoweixiong@allwinnertech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1561424549-784-1-git-send-email-liaoweixiong@allwinnertech.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote: > In case of the last page containing bitflips (ret > 0), > spinand_mtd_read() will return that number of bitflips for the last > page. But to me it looks like it should instead return max_bitflips like > it does when the last page read returns with 0. > > Signed-off-by: liaoweixiong > Reviewed-by: Boris Brezillon > Reviewed-by: Frieder Schrempf > Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") > --- > drivers/mtd/nand/spi/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.