Re: [PATCH V2 08/15] ARM: mmp: cleanup cppcheck shifting errors

Russell King - ARM Linux admin
2019-06-24T13:59:58Z

On Mon, Jun 24, 2019 at 08:50:58PM +0700, Phong Tran wrote:
> #define MPMU_PLL2_CTRL1 MPMU_REG(0x0414)
> #define MPMU_CGR_PJ MPMU_REG(0x1024)
> #define MPMU_WUCRM_PJ MPMU_REG(0x104c)
> -#define MPMU_WUCRM_PJ_WAKEUP(x) (1 << (x))
> -#define MPMU_WUCRM_PJ_RTC_ALARM (1 << 17)
> +#define MPMU_WUCRM_PJ_WAKEUP(x) BIT((x))

Extra parens not required.

> +#define MPMU_AWUCRM_WAKEUP(x) BIT(((x) & 0x7))

Ditto.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up