Re: [PATCH V2 00/15] cleanup cppcheck signed shifting errors

Peter Zijlstra
2019-06-24T15:29:32Z

On Mon, Jun 24, 2019 at 05:27:43PM +0200, Peter Zijlstra wrote:
> On Mon, Jun 24, 2019 at 08:50:50PM +0700, Phong Tran wrote:
> > There are errors with cppcheck
> >
> > "Shifting signed 32-bit value by 31 bits is undefined behaviour errors"
>
> As I've already told you; your checker is bad. That is not in face

Bah, fact, typing hard.

> undefined behaviour in the kernel.
>
> That's not to say you shouldn't clean up the code, but don't give broken
> checkout output as a reason.