From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1933C48BD5 for ; Tue, 25 Jun 2019 07:52:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A73B92086D for ; Tue, 25 Jun 2019 07:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561449145; bh=nyNszpfiaOPivEGutVbzOgMkeimehfcQz+veqfeZZXM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Myiovg/6djwOuzoY4Szo9VFGJQ/dBK2q+sT+F+aFua/r2uS8MsLDNgyPxDrDCPWpV /rWD/FtKz37AfXG36iVVXs3VIuZq/dAEPLh1tE3hdGCJX/aBWo8i+4GHVhQXGXH+hI wgGkusFhffBidhBc7XqMZj60ebuNFX97tnH02uuk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728137AbfFYHwY (ORCPT ); Tue, 25 Jun 2019 03:52:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:38988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726419AbfFYHwX (ORCPT ); Tue, 25 Jun 2019 03:52:23 -0400 Received: from localhost (f4.8f.5177.ip4.static.sl-reverse.com [119.81.143.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FBBB20665; Tue, 25 Jun 2019 07:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561449142; bh=nyNszpfiaOPivEGutVbzOgMkeimehfcQz+veqfeZZXM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c9oPEbSzQ71W7SK0QFmDGaV4vKsZ5g1p5Rrlx4ckF6BKBk+fJboJ12Oix62mFkuB/ kO+XQvmLKZ/OwST/4/K8CO3i4EwWfan/EiYiAz35jHfsy+FPkstK+q4PgpwlgVS4fb O7JvbaDaBRxhKRfU4nrucorZ4sn4kdVUi8Oo/Za4= Date: Tue, 25 Jun 2019 15:50:29 +0800 From: Greg KH To: Ignat Korchagin Cc: Arnaldo Carvalho de Melo , Ivan Babrou , Miguel Ojeda , Peter Zijlstra , Josh Poimboeuf , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-kernel , Linux Kbuild mailing list , kernel-team Subject: Re: Linux 4.19 and GCC 9 Message-ID: <20190625075029.GC19452@kroah.com> References: <20190517085126.GA3249@kroah.com> <20190517152200.GI8945@kernel.org> <4FE2D490-F379-4CAE-9784-9BF81B7FE258@kernel.org> <20190610151407.GS21245@kernel.org> <20190610152542.GA4132@kroah.com> <20190610191417.GW21245@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 24, 2019 at 11:42:34AM +0100, Ignat Korchagin wrote: > Hi Greg, > > > > For us it seems applying the following 4 mainline patches makes 4.19.x > > > branch perf compile with GCC-9: > > > > > > 4d0f16d059ddb91424480d88473f7392f24aebdc: perf ui helpline: Use > > > strlcpy() as a shorter form of strncpy() + explicit set nul > > > b6313899f4ed2e76b8375cf8069556f5b94fbff0: perf help: Remove needless > > > use of strncpy() > > > 5192bde7d98c99f2cd80225649e3c2e7493722f7: perf header: Fix unchecked > > > usage of strncpy() > > > 97acec7df172cd1e450f81f5e293c0aa145a2797: perf data: Fix 'strncat may > > > truncate' build failure with recent gcc > > > > > > I also checked that 4.19.49 compiles fine with GCC 9, although with a > > > lot of warnings, mostly from objtool, like "warning: objtool: > > > sock_register()+0xd: sibling call from callable instruction with > > > modified stack frame". But it's a start. > > > > > > Can we apply the above-mentioned patches, please? > > > I'll look into these after the next round of kernels are released. I > > Did you by any chance forget to queue these patches? :) (the build is > still broken for GCC 9.1) I am on the road and getting to backports for this stuff is on the bottom of my list until next week at the earliest, sorry. > > guess I'll go find a distro that has gcc9 on it to actually test > > things... > > BTW, Arch already has GCC 9.1 package, so no need to compile your own > anymore for testing: > https://www.archlinux.org/packages/core/x86_64/gcc/ Yes, my laptop just updated, so I'm building here. Some gcc9 patches did just get backported, but not for perf. thanks, greg k-h