public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Fabian Krueger <fabian.krueger@fau.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Michael Scheiderer <michael.scheiderer@fau.de>
Subject: Re: [PATCH 6/8] staging: kpc2000: introduce 'unsigned int'
Date: Tue, 25 Jun 2019 14:55:22 +0300	[thread overview]
Message-ID: <20190625115522.GC28859@kadam> (raw)
In-Reply-To: <20190625112725.10154-7-fabian.krueger@fau.de>

On Tue, Jun 25, 2019 at 01:27:17PM +0200, Fabian Krueger wrote:
> Replaced 'unsigned' with it's equivalent 'unsigned int' to reduce
> confusion while reading the code.
> 
> Signed-off-by: Fabian Krueger <fabian.krueger@fau.de>
> Signed-off-by: Michael Scheiderer <michael.scheiderer@fau.de>
> ---
>  drivers/staging/kpc2000/kpc2000_spi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c
> index 79d7c44315e8..732254e9b261 100644
> --- a/drivers/staging/kpc2000/kpc2000_spi.c
> +++ b/drivers/staging/kpc2000/kpc2000_spi.c
> @@ -337,7 +337,7 @@ kp_spi_transfer_one_message(struct spi_master *master, struct spi_message *m)
>  	list_for_each_entry(transfer, &m->transfers, transfer_list) {
>  		const void *tx_buf = transfer->tx_buf;
>  		void       *rx_buf = transfer->rx_buf;
> -		unsigned    len = transfer->len;
> +		unsigned int   len = transfer->len;
                            ^^^^
This white space isn't correct.

regards,
dan carpenter


  reply	other threads:[~2019-06-25 11:55 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25 11:27 [PATCH 0/8] staging: kpc2000: style refactoring Fabian Krueger
2019-06-25 11:27 ` [PATCH 1/8] staging: kpc2000: add line breaks Fabian Krueger
2019-06-25 11:52   ` Dan Carpenter
2019-06-26  7:35     ` [PATCH 0/8] staging: kpc2000: style refactoring Fabian Krueger
2019-06-26  7:35       ` [PATCH 1/8] staging: kpc2000: add line breaks Fabian Krueger
2019-07-01  8:41         ` Greg Kroah-Hartman
2019-06-26  7:35       ` [PATCH 2/8] staging: kpc2000: blank lines after declaration Fabian Krueger
2019-06-26  7:35       ` [PATCH 3/8] staging: kpc2000: introduce usage of __packed Fabian Krueger
2019-06-26  7:35       ` [PATCH 4/8] staging: kpc2000: remove unnecessary brackets Fabian Krueger
2019-06-26  7:35       ` [PATCH 5/8] staging: kpc2000: add spaces Fabian Krueger
2019-06-26  7:35       ` [PATCH 6/8] staging: kpc2000: introduce 'unsigned int' Fabian Krueger
2019-06-26  7:35       ` [PATCH 7/8] staging: kpc2000: introduce __func__ Fabian Krueger
2019-06-26  7:35       ` [PATCH 8/8] staging: kpc2000: remove needless 'break' Fabian Krueger
2019-06-26  7:50       ` [PATCH 0/8] staging: kpc2000: style refactoring Dan Carpenter
2019-06-25 11:27 ` [PATCH 2/8] staging: kpc2000: blank lines after declaration Fabian Krueger
2019-06-25 11:27 ` [PATCH 3/8] staging: kpc2000: introduce usage of __packed Fabian Krueger
2019-06-25 11:27 ` [PATCH 4/8] staging: kpc2000: add spaces Fabian Krueger
2019-06-25 11:54   ` Dan Carpenter
2019-06-25 11:27 ` [PATCH 5/8] staging: kpc2000: remove unnecessary brackets Fabian Krueger
2019-06-25 11:27 ` [PATCH 6/8] staging: kpc2000: introduce 'unsigned int' Fabian Krueger
2019-06-25 11:55   ` Dan Carpenter [this message]
2019-06-25 11:27 ` [PATCH 7/8] staging: kpc2000: introduce __func__ Fabian Krueger
2019-06-25 11:27 ` [PATCH 8/8] staging: kpc2000: remove needless 'break' Fabian Krueger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190625115522.GC28859@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=fabian.krueger@fau.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.scheiderer@fau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox