Re: [PATCH 11/12] iomap: move the xfs writeback code to iomap.c

Christoph Hellwig
2019-06-25T10:10:53Z

On Tue, Jun 25, 2019 at 09:43:04AM +1000, Dave Chinner wrote:
> I'm a little concerned this is going to limit what we can do
> with the XFS IO path because now we can't change this code without
> considering the direct impact on other filesystems. The QA burden of
> changing the XFS writeback code goes through the roof with this
> change (i.e. we can break multiple filesystems, not just XFS).

Going through the roof is a little exaggerated. Yes, it will be more
testing overhead, but that is life in a world where we try to share
code rather than duplicating it, which is pretty much a general
kernel policy that has served us well.

> The writepage code is one of the areas that, historically speaking,
> has one of the highest rates of modification in XFS - we've
> substantially reworked this code from top to bottom 4 or 5 times in
> a bit over ten years, and each time it's been removing abstraction
> layers and getting the writeback code closer to the internal XFS
> extent mapping infrastructure.

I don't think we had all that much churn. Yes, we've improved it a
lot, but much of that was in response to core changes, and pretty much
all of it benefits other users as well. And the more users we have
for this infrastructure that more clout it has with core VM folks
when we have to push back odd design decisions.