From: Segher Boessenkool <segher@kernel.crashing.org>
To: Mathieu Malaterre <malat@debian.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Joel Stanley <joel@jms.id.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lib/mpi: fix build with clang
Date: Tue, 25 Jun 2019 13:15:49 -0500 [thread overview]
Message-ID: <20190625181549.GK7313@gate.crashing.org> (raw)
In-Reply-To: <20190621195555.20615-1-malat@debian.org>
Hi Mathieu,
On Fri, Jun 21, 2019 at 09:55:54PM +0200, Mathieu Malaterre wrote:
> Remove superfluous casts on output operands to avoid warnings on the
> following macros:
>
> * add_ssaaaa(sh, sl, ah, al, bh, bl)
> * sub_ddmmss(sh, sl, ah, al, bh, bl)
> * umul_ppmm(ph, pl, m0, m1)
The patch is fine of course, but you might want to look at not using
these asm macros at all: GCC can handle multi-word arithmetic just fine
by itself, probably better than these macros do even.
Segher
prev parent reply other threads:[~2019-06-25 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 7:13 [PATCH] crypto: Fix build for clang Mathieu Malaterre
2019-06-21 7:29 ` Joel Stanley
2019-06-21 7:44 ` Mathieu Malaterre
2019-06-21 19:55 ` [PATCH v2] lib/mpi: fix build with clang Mathieu Malaterre
2019-06-25 4:03 ` Joel Stanley
2019-06-25 18:15 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625181549.GK7313@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=malat@debian.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox