Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

Joe Lawrence
2019-08-19T16:02:28Z

On 8/19/19 3:31 AM, Miroslav Benes wrote:
> On Mon, 19 Aug 2019, Masahiro Yamada wrote:
>
>>
>> I can review this series from the build system point of view,
>> but I am not familiar enough with live-patching itself.
>>
>> Some possibilities:
>>
>> [1] Merge this series thru the live-patch tree after the
>> kbuild base patches land.
>> This requires one extra development cycle (targeting for 5.5-rc1)
>> but I think this is the official way if you do not rush into it.
>
> I'd prefer this option. There is no real rush and I think we can wait one
> extra development cycle.

Agreed. I'm in no hurry and was only curious about the kbuild changes
that this patchset is now dependent on -- how to note them for other
reviewers or anyone wishing to test.

> Joe, could you submit one more revision with all the recent changes (once
> kbuild improvements settle down), please? We should take a look at the
> whole thing one more time? What do you think?
>

Definitely, yes. I occasionally force a push to:
https://github.com/joe-lawrence/linux/tree/klp-convert-v5-expanded

as I've been updating and collecting feedback from v4. Once updates
settle, I'll send out a new v5 set.

-- Joe