From: Greg KH <gregkh@linuxfoundation.org>
To: "Simon Sandström" <simon@nikanor.nu>
Cc: devel@driverdev.osuosl.org, gneukum1@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] staging: kpc2000: remove unnecessary parentheses in kpc2000_spi.c
Date: Wed, 26 Jun 2019 09:56:22 +0800 [thread overview]
Message-ID: <20190626015622.GC30966@kroah.com> (raw)
In-Reply-To: <20190625084130.1107-4-simon@nikanor.nu>
On Tue, Jun 25, 2019 at 10:41:29AM +0200, Simon Sandström wrote:
> Fixes checkpatch "CHECK: Unnecessary parentheses around '...'".
>
> Signed-off-by: Simon Sandström <simon@nikanor.nu>
> ---
> drivers/staging/kpc2000/kpc2000_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c
> index 98484fbb9d2e..68b049f9ad69 100644
> --- a/drivers/staging/kpc2000/kpc2000_spi.c
> +++ b/drivers/staging/kpc2000/kpc2000_spi.c
> @@ -164,7 +164,7 @@ kp_spi_read_reg(struct kp_spi_controller_state *cs, int idx)
> u64 val;
>
> addr += idx;
> - if ((idx == KP_SPI_REG_CONFIG) && (cs->conf_cache >= 0)) {
> + if (idx == KP_SPI_REG_CONFIG && cs->conf_cache >= 0) {
Ick, no. I don't want to have to remember the priority order of
operations. Leave this as-is, I HATE this checkpatch message.
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-26 2:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 8:41 [PATCH 0/4] Minor style issue fixes for staging/kpc2000 Simon Sandström
2019-06-25 8:41 ` [PATCH 1/4] staging: kpc2000: add missing spaces in kpc2000_i2c.c Simon Sandström
2019-06-25 8:41 ` [PATCH 2/4] staging: kpc2000: add missing spaces in kpc2000_spi.c Simon Sandström
2019-06-25 8:41 ` [PATCH 3/4] staging: kpc2000: remove unnecessary parentheses " Simon Sandström
2019-06-26 1:56 ` Greg KH [this message]
2019-06-25 8:41 ` [PATCH 4/4] staging: kpc2000: fix brace issues " Simon Sandström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626015622.GC30966@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=gneukum1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@nikanor.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox