From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5767BC48BD5 for ; Wed, 26 Jun 2019 02:03:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FBBA205C9 for ; Wed, 26 Jun 2019 02:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561514613; bh=62LoSwtXHpbnbCH3C/+D4GuQrQ/r6+lINTf9IHhDVnM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=lHIDt8c9YVYQMQ9Paqpeu0xy906jOSfyDZMULAbuluZE3tugDiXZhx0+43lrEu3I4 x98kbVADpAG856/2hcgMVU/kYn+QdSRTo6G8LTUy/XwDMcofIlOScu871ktV6RavvP uehbNlMLUdOLoLpXnS5aupsoI/s7qZRaMXIU99Ww= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726519AbfFZCDb (ORCPT ); Tue, 25 Jun 2019 22:03:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:56314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbfFZCDb (ORCPT ); Tue, 25 Jun 2019 22:03:31 -0400 Received: from localhost (li1825-44.members.linode.com [172.104.248.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA084205C9; Wed, 26 Jun 2019 02:03:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561514610; bh=62LoSwtXHpbnbCH3C/+D4GuQrQ/r6+lINTf9IHhDVnM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sr8P26hcL0mrsOSIY0mf890uVjyghZvny3f090YK7szhXZlagCeOLKvIC7BI4g7jR QXaWTARPZX5eE28hPdMWtULJgLCVIt6DmZDEwQg/32U7uiUVJdfgrNVNFWxUk6jgWO /84SYo0QztGQ6Mqh98fQUdpCDzzi6PaYLNbw+lNA= Date: Wed, 26 Jun 2019 09:56:22 +0800 From: Greg KH To: Simon =?iso-8859-1?Q?Sandstr=F6m?= Cc: devel@driverdev.osuosl.org, gneukum1@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] staging: kpc2000: remove unnecessary parentheses in kpc2000_spi.c Message-ID: <20190626015622.GC30966@kroah.com> References: <20190625084130.1107-1-simon@nikanor.nu> <20190625084130.1107-4-simon@nikanor.nu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190625084130.1107-4-simon@nikanor.nu> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 25, 2019 at 10:41:29AM +0200, Simon Sandström wrote: > Fixes checkpatch "CHECK: Unnecessary parentheses around '...'". > > Signed-off-by: Simon Sandström > --- > drivers/staging/kpc2000/kpc2000_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c > index 98484fbb9d2e..68b049f9ad69 100644 > --- a/drivers/staging/kpc2000/kpc2000_spi.c > +++ b/drivers/staging/kpc2000/kpc2000_spi.c > @@ -164,7 +164,7 @@ kp_spi_read_reg(struct kp_spi_controller_state *cs, int idx) > u64 val; > > addr += idx; > - if ((idx == KP_SPI_REG_CONFIG) && (cs->conf_cache >= 0)) { > + if (idx == KP_SPI_REG_CONFIG && cs->conf_cache >= 0) { Ick, no. I don't want to have to remember the priority order of operations. Leave this as-is, I HATE this checkpatch message. thanks, greg k-h