Re: [PATCH AUTOSEL 5.1 07/51] ASoC: soc-dpm: fixup DAI active unbalance

Mark Brown
2019-07-01T16:18:08Z

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

On Wed, Jun 26, 2019 at 08:20:59PM -0400, Sasha Levin wrote:
> On Wed, Jun 26, 2019 at 11:03:15AM +0100, Mark Brown wrote:
> > On Tue, Jun 25, 2019 at 11:40:23PM -0400, Sasha Levin wrote:

> > > [ Upstream commit f7c4842abfa1a219554a3ffd8c317e8fdd979bec ]

> > > snd_soc_dai_link_event() is updating snd_soc_dai :: active,
> > > but it is unbalance.
> > > It counts up if it has startup callback.

> > Are you *sure* this doesn't have dependencies?

> The actual code seems to correspond with the issue described in the
> commit message, so I'd think not.

> I can remove this patch if you're not confident about it.

I'm not entirely, no.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]