Re: [PATCH 3/4] regulator: Add regulator driver for ATC260x PMICs

Manivannan Sadhasivam
2019-06-17T16:34:23Z

Hi Mark,

On Mon, Jun 17, 2019 at 05:30:15PM +0100, Mark Brown wrote:
> On Mon, Jun 17, 2019 at 09:20:10PM +0530, Manivannan Sadhasivam wrote:
>
> > +++ b/drivers/regulator/atc260x-regulator.c
> > @@ -0,0 +1,389 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Regulator driver for ATC260x PMICs
>
> Please make the entire comment a C++ one so this looks more intentional.
>

Okay.

> > + * Copyright (C) 2019 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> You definitely didn't assign copyright to your employer?

Yeah, that was intentional. This work is not part of Linaro working hours and
falls into my spare time works where I'm trying to complete the upstream support
for Actions Semi Owl series SoCs and target boards which I'm co-maintaining
(sort of)...

Thanks,
Mani