Re: [PATCH 3/4] regulator: Add regulator driver for ATC260x PMICs

Mark Brown
2019-06-17T16:54:11Z

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

On Mon, Jun 17, 2019 at 06:38:53PM +0200, Andreas Färber wrote:
> Am 17.06.19 um 18:34 schrieb Manivannan Sadhasivam:
> > On Mon, Jun 17, 2019 at 05:30:15PM +0100, Mark Brown wrote:

> >>> @@ -0,0 +1,389 @@
> >>> +// SPDX-License-Identifier: GPL-2.0+
> >>> +/*
> >>> + * Regulator driver for ATC260x PMICs

> >> Please make the entire comment a C++ one so this looks more intentional.

> No, this is intentional and the official style requested by GregKH.

The important bit for the tools is the first line, the rest of it the
tools don't care about.

> He suggested I patch the SPDX documentation to make this clearer, but I
> did not find time for this yet (and am not the one making this rule).

The other regulator API files are all the way I suggest...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]