public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Ankur Arora <ankur.a.arora@oracle.com>,
	Joao Martins <joao.m.martins@oracle.com>
Cc: Wanpeng Li <kernellwp@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Radim Krcmar <rkrcmar@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	KarimAllah <karahmed@amazon.de>,
	LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>
Subject: Re: cputime takes cstate into consideration
Date: Wed, 26 Jun 2019 10:54:13 -0400	[thread overview]
Message-ID: <20190626145413.GE6753@char.us.oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1906261211410.32342@nanos.tec.linutronix.de>

On Wed, Jun 26, 2019 at 12:33:30PM +0200, Thomas Gleixner wrote:
> On Wed, 26 Jun 2019, Wanpeng Li wrote:
> > After exposing mwait/monitor into kvm guest, the guest can make
> > physical cpu enter deeper cstate through mwait instruction, however,
> > the top command on host still observe 100% cpu utilization since qemu
> > process is running even though guest who has the power management
> > capability executes mwait. Actually we can observe the physical cpu
> > has already enter deeper cstate by powertop on host. Could we take
> > cstate into consideration when accounting cputime etc?
> 
> If MWAIT can be used inside the guest then the host cannot distinguish
> between execution and stuck in mwait.
> 
> It'd need to poll the power monitoring MSRs on every occasion where the
> accounting happens.
> 
> This completely falls apart when you have zero exit guest. (think
> NOHZ_FULL). Then you'd have to bring the guest out with an IPI to access
> the per CPU MSRs.
> 
> I assume a lot of people will be happy about all that :)

There were some ideas that Ankur (CC-ed) mentioned to me of using the perf
counters (in the host) to sample the guest and construct a better
accounting idea of what the guest does. That way the dashboard
from the host would not show 100% CPU utilization.

But the patches that Marcelo posted (" cpuidle-haltpoll driver") in 
"solves" the problem for Linux. That is the guest wants awesome latency and
one way was to expose MWAIT to the guest, or just tweak the guest to do the
idling a bit different.

Marcelo patches are all good for Linux, but Windows is still an issue.

Ankur, would you be OK sharing some of your ideas?
> 
> Thanks,
> 
> 	tglx
> 

  reply	other threads:[~2019-06-26 14:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26  9:43 cputime takes cstate into consideration Wanpeng Li
2019-06-26 10:13 ` Peter Zijlstra
2019-06-26 10:33 ` Thomas Gleixner
2019-06-26 14:54   ` Konrad Rzeszutek Wilk [this message]
2019-06-26 16:16     ` Peter Zijlstra
2019-06-26 18:30       ` Konrad Rzeszutek Wilk
2019-06-26 18:41         ` Thomas Gleixner
2019-06-26 18:55           ` Raslan, KarimAllah
2019-06-26 19:19             ` Thomas Gleixner
2019-06-26 19:21             ` Peter Zijlstra
2019-06-26 19:27               ` Raslan, KarimAllah
2019-06-26 19:32                 ` Thomas Gleixner
2019-06-26 20:01                 ` Peter Zijlstra
2019-06-26 20:09                   ` Thomas Gleixner
2019-12-10  0:44                 ` Wanpeng Li
2019-06-26 19:29               ` Thomas Gleixner
2019-06-26 18:58     ` Raslan, KarimAllah
2019-06-26 19:23       ` Thomas Gleixner
2019-07-09  2:00         ` Ankur Arora
2019-07-09  2:06           ` Wanpeng Li
2019-07-09 12:38           ` Peter Zijlstra
2019-07-09 18:27             ` Ankur Arora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626145413.GE6753@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=ankur.a.arora@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=joao.m.martins@oracle.com \
    --cc=karahmed@amazon.de \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox