Re: [PATCH v3 0/2] Support accelerometers for veyron_minnie

Enric Balletbo i Serra
2019-06-25T17:09:56Z

Hi,

On 25/6/19 0:53, Gwendal Grignou wrote:
> veyron_minnie - ASUS Chromebook Flip C100PA - embedded controller
> controls two accelerometers, one in the lid, one in the base.
> However, the EC firmware does not follow the new interface that
> cros_ec_accel driver use.
> Extend the legacy driver used on glimmer - Lenovo ThinkPad 11e
> Chromebook - to veyron_minnie.
> veyron_minnie being ARM based, issue command over the I2C bus to the EC
> instead of relying on the shared registers over LPC.
>
> Gwendal Grignou (2):
> iio: cros_ec: Add sign vector in core for backward compatibility
> iio: cros_ec: Extend legacy support to ARM device
>
> Changes in v3:
> - Fix commit message, add reviewed-by for first patch.
>
> Changes in v2:
> - Readd empty line to reduce amount of change in patch.
> - Remove Keywords used by ChromeOS commit queue.
>
> drivers/iio/accel/Kconfig | 4 +-
> drivers/iio/accel/cros_ec_accel_legacy.c | 350 ++++--------------
> .../cros_ec_sensors/cros_ec_sensors_core.c | 4 +
> .../linux/iio/common/cros_ec_sensors_core.h | 1 +
> 4 files changed, 84 insertions(+), 275 deletions(-)
>

Just a side note that I think that this patch depends on [1] to have the legacy
sensors working on veyron minnie.

For the full series:

Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

[1] https://lkml.org/lkml/2019/6/18/268