Re: [PATCH 4/4] iio: frequency: adf4371: Add support for output stage mute

Jonathan Cameron
2019-06-26T20:13:39Z

On Wed, 26 Jun 2019 13:59:49 -0600
Rob Herring <robh+dt@kernel.org> wrote:

> On Mon, Jun 24, 2019 at 9:14 AM Stefan Popa <stefan.popa@analog.com> wrote:
> >
> > Another feature of the ADF4371/ADF4372 is that the supply current to the
> > RF8P and RF8N output stage can shut down until the ADF4371 achieves lock
> > as measured by the digital lock detect circuitry. The mute to lock
> > detect bit (MUTE_LD) in REG25 enables this function.
> >
> > Signed-off-by: Stefan Popa <stefan.popa@analog.com>
> > ---
> > .../devicetree/bindings/iio/frequency/adf4371.yaml | 6 ++++++
>
> If you resend and in the future, please split bindings to separate patch.
>
> > drivers/iio/frequency/adf4371.c | 13 +++++++++++++
> > 2 files changed, 19 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > index a268a9d..6db8742 100644
> > --- a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > +++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > @@ -32,6 +32,12 @@ properties:
> > items:
> > - clkin
> >
> > + adi,mute-till-lock-en:
> > + description:
> > + If this property is present, then the supply current to RF8P and RF8N
> > + output stage will shut down until the ADF4371/ADF4372 achieves lock as
> > + measured by the digital lock detect circuitry.
>
> You need to define the type:
>
> type: boolean
>
> Maybe Jonathan will fix up.
Doh. I should have caught that.

Fixed up with
type: boolean

Hopefully I did it right

https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=testing&id=6e68162fcc94ec81c1656e15e6e1893fee0c309a

Thanks Rob!

Jonathan

>
> Rob