From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34A27C48BD6 for ; Wed, 26 Jun 2019 21:20:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04F4221743 for ; Wed, 26 Jun 2019 21:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561584021; bh=bsNDLJo9ltp2da5EquRLxAgPPry7BtafSZzY75/F/NU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=j3m7gBD4mSdQ0YLl2SvjJYghSJO8rFJJ56x5Y5XFaQzrLH/SnYbrWNccUAsTefDcd GWX+UH8+LoYeRJCcSwfmS+QdUxjRvW4HjDCypE1WE3/p3+iU5mD8gtBZ9xAJRwjUvl l67WomH/MX+wu4tj8/YLAf7IDhJLjbXheX1J5ySo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726443AbfFZVUT (ORCPT ); Wed, 26 Jun 2019 17:20:19 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:51399 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726223AbfFZVUT (ORCPT ); Wed, 26 Jun 2019 17:20:19 -0400 Received: by mail-wm1-f65.google.com with SMTP id 207so3560709wma.1 for ; Wed, 26 Jun 2019 14:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0DtFqszsr3qJYqKdyDfqtNM2KkK1DcaCWoxZcO7W0sI=; b=dvYr6HuZFPqose6JEl5JScrwn2WfYFDWGYGVKHTBf0StaVq86QFFjFB1pVno2syJhU tOeyX8aGu1TM9h3MNaP4xZ6NcNZBm7Ap0inzYVlrex7Tjqd3C8BuPu+ENsZ+Wq8ajyVq n+5iA1bxvfGLfcnp6f6JMY/+9HkUjo7NXmXBN/4SGiJx8dehB9e9hKps36omIaY/alyW q4Tg2TG5ILXGn5CJbYn5fA9JqK0DirENheLbzBGC+51FANRAvxQQMZ4jZ4Z//z0TbsjS LNEDGtPhwg2Ep+N8f0RT+eveeBruifCQJTuJzPNGCTNXJzJvQZHBzHfXmAHzOWVmrCYr +TIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=0DtFqszsr3qJYqKdyDfqtNM2KkK1DcaCWoxZcO7W0sI=; b=h2yF9UVfY1zYSu5rJVrUuI4XRJJ4gEM4GZJN8bLpHtge2hK/RIY4FdpS1LU/AwaFdn Tmrtz1OqBXWFKQyLQ9PCdJ5l5pZSVSSb2Bfh1rid9AfhXfk49B4AW+uZzlhrcXjVeu99 5GP9huWP5bLT9TxIomPKDP9t/qC6tRiusCHIztginM1L56dbUbyorN6qUhyfftSl1qlf MY7sq81f/2kMEWblEqqWg+GydAUT2QfIN2UwACg23XB8Mxd0msPtXJwTHd4V4KP/Yyr/ 0vc7QAO04ZjZPLIdDi9B565gIo5V2MIwiFPxrC8/fWMEepHts/Qzbwhw1QSPnHSx39lJ ytrg== X-Gm-Message-State: APjAAAX63VhtGILGpKDo0va8s4BbPyLxv75amjZP3bQeXN8Joxf6Jf4Q QF3+INq8kLZRu86yfqUxJGQ= X-Google-Smtp-Source: APXvYqyuvOaPAPzC1vcGqF5fygDlBPVn5tHNksOdZJf7VQhfOe3P/OPsxR6s71nPVBliZC8WGDAy9Q== X-Received: by 2002:a1c:4b1a:: with SMTP id y26mr577121wma.105.1561584017187; Wed, 26 Jun 2019 14:20:17 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id m24sm434823wmi.39.2019.06.26.14.20.16 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 26 Jun 2019 14:20:16 -0700 (PDT) Date: Wed, 26 Jun 2019 23:20:14 +0200 From: Ingo Molnar To: Thomas Gleixner Cc: LKML , x86@kernel.org, Peter Zijlstra , Ricardo Neri , Ashok Raj , Andi Kleen , Suravee Suthikulpanit , Stephane Eranian , Ravi Shankar Subject: Re: [patch 24/29] x86/hpet: Use cached info instead of extra flags Message-ID: <20190626212014.GC101255@gmail.com> References: <20190623132340.463097504@linutronix.de> <20190623132436.277510163@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190623132436.277510163@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Thomas Gleixner wrote: > Now that HPET clockevent support is integrated into the channel data, reuse > the cached boot configuration instead of copying the same information into > a flags field. > > This also allows to consolidate the reservation code into one place, which > can now solely depend on the mode information. > > Signed-off-by: Thomas Gleixner > --- > arch/x86/kernel/hpet.c | 76 ++++++++++++++----------------------------------- > 1 file changed, 23 insertions(+), 53 deletions(-) > > --- a/arch/x86/kernel/hpet.c > +++ b/arch/x86/kernel/hpet.c > @@ -25,8 +25,8 @@ struct hpet_channel { > unsigned int num; > unsigned int cpu; > unsigned int irq; > + unsigned int inuse; > enum hpet_mode mode; > - unsigned int flags; > unsigned int boot_cfg; > char name[10]; Let's fight entropy name by name and s/inuse/in_use ? Because in_use is closer to harmony: dagon:~/tip> git grep -w in_use | wc -l 518 dagon:~/tip> git grep -w inuse | wc -l 318 and also easier to read. Reviewed-by: Ingo Molnar Thanks, Ingo