From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5525BC48BD7 for ; Thu, 27 Jun 2019 13:22:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 288FF2083B for ; Thu, 27 Jun 2019 13:22:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726811AbfF0NWO (ORCPT ); Thu, 27 Jun 2019 09:22:14 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:51571 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbfF0NWO (ORCPT ); Thu, 27 Jun 2019 09:22:14 -0400 X-Originating-IP: 92.137.69.152 Received: from localhost (alyon-656-1-672-152.w92-137.abo.wanadoo.fr [92.137.69.152]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id BD3BD1C0011; Thu, 27 Jun 2019 13:22:00 +0000 (UTC) Date: Thu, 27 Jun 2019 15:22:00 +0200 From: Alexandre Belloni To: Wolfram Sang Cc: Eugen.Hristev@microchip.com, peda@axentia.se, robh+dt@kernel.org, mark.rutland@arm.com, Nicolas.Ferre@microchip.com, Ludovic.Desroches@microchip.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Pierre-Yves MORDRET Subject: Re: I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt) Message-ID: <20190627132200.GK3692@piout.net> References: <1561449642-26956-1-git-send-email-eugen.hristev@microchip.com> <1561449642-26956-7-git-send-email-eugen.hristev@microchip.com> <4e81d3c9-25f3-ca6e-f2d5-17fad5905bb8@axentia.se> <84628b5e-bea7-7d91-f790-f3a2650040fa@microchip.com> <20190625093156.GF5690@piout.net> <20190625095533.GC1688@kunai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190625095533.GC1688@kunai> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/06/2019 11:55:33+0200, Wolfram Sang wrote: > On Tue, Jun 25, 2019 at 11:31:56AM +0200, Alexandre Belloni wrote: > > On 25/06/2019 09:14:13+0000, Eugen.Hristev@microchip.com wrote: > > > > Perhaps > > > > > > > > microchip,digital-filter; > > > > microchip,analog-filter; > > > > > > > > ? > > > > > > Hi Peter, > > > > > > Thanks for reviewing. The name of the property does not matter much to > > > me, and we have properties prefixed with vendor, and some are not. > > > > > > @Alexandre Belloni: which name you think it's best ? > > > > > > > I'm not sure, it depends on whether Wolfram thinks it is generic enough > > to be used without a vendor prefix. > > I could imagine that we design a generic property for filters. The ones > above make me wonder, though, because they are bool. I'd think you can > configure the filters in some way, too? > Apart from enabling the filter there is indeed one configuration setting, the maximum pulse width of spikes to be suppressed by the input filter. > I never used such filtering, so I am unaware of the parameters needed / > suitable. Quick grepping through I2C master drivers reveals that > i2c-stm32f7.c also handles filters, but only with default values. Maybe > DT configuration would be benefitial to that driver, too? > > Adding some people to CC. > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com