From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4012C48BD6 for ; Thu, 27 Jun 2019 16:34:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C130E2133F for ; Thu, 27 Jun 2019 16:34:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbfF0QeH (ORCPT ); Thu, 27 Jun 2019 12:34:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36034 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbfF0QeG (ORCPT ); Thu, 27 Jun 2019 12:34:06 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6871C3082B4D; Thu, 27 Jun 2019 16:33:59 +0000 (UTC) Received: from krava (unknown [10.43.17.81]) by smtp.corp.redhat.com (Postfix) with SMTP id B8DB060BE0; Thu, 27 Jun 2019 16:33:52 +0000 (UTC) Date: Thu, 27 Jun 2019 18:33:52 +0200 From: Jiri Olsa To: John Garry Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, namhyung@kernel.org, tmricht@linux.ibm.com, brueckner@linux.ibm.com, kan.liang@linux.intel.com, ben@decadent.org.uk, mathieu.poirier@linaro.org, mark.rutland@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linuxarm@huawei.com, linux-arm-kernel@lists.infradead.org, zhangshaokun@hisilicon.com Subject: Re: [PATCH v2 2/5] perf pmu: Support more complex PMU event aliasing Message-ID: <20190627163352.GE24279@krava> References: <1560521283-73314-1-git-send-email-john.garry@huawei.com> <1560521283-73314-3-git-send-email-john.garry@huawei.com> <20190616095844.GC2500@krava> <20190620182519.GA15239@krava> <6257fc79-b737-e6ca-2fce-f71afa36e9aa@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 27 Jun 2019 16:34:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 27, 2019 at 05:27:32PM +0100, John Garry wrote: SNIP > > loop 2. tok=ddrc name=ddrc0 > > loop 3. tok=NULL -> breakout and return true > > > > A couple of notes: > > a. loop 1. could be omitted, but the code becomes a bit more complicated > > 2. I don't have to advance name. But then we would match something like > > hisi_ddrc0_sccl1. Maybe this is ok. > > > > > > > > and name is still pmu with no ',' ... > > > please make this or > > > proper version that in some comment > > > > > > > I didn't really get your meaning here. Please check my replies and see > > if you have further doubt or concern. > > > > Hi Jirka, > > I was just wondering if you have any further comments or questions here? > > Much appreciated, sorry, forgot about this one.. will check soon jirka