Re: [PATCH v4 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings

Miquel Raynal
2019-06-28T07:43:03Z

Hi Mason,

Please always Cc: Rob (robh+dt@kernel.org) when you send bindings
related patches.

masonccyang@mxic.com.tw wrote on Fri, 28 Jun 2019
14:48:02 +0800:

> Hi Miquel,
>
> > > Document the bindings used by the Macronix raw NAND controller.
> > >
> > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> > > ---
> > > .../devicetree/bindings/mtd/mxic-nand.txt | 26
> ++++++++++++++++++++++
> > > 1 file changed, 26 insertions(+)
> > > create mode 100644
> Documentation/devicetree/bindings/mtd/mxic-nand.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/mtd/mxic-nand.txt b/
> > Documentation/devicetree/bindings/mtd/mxic-nand.txt
> > > new file mode 100644
> > > index 0000000..3d198e4
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mtd/mxic-nand.txt
> > > @@ -0,0 +1,26 @@
> > > +Macronix Raw NAND Controller Device Tree Bindings
> > > +-------------------------------------------------
> > > +
> > > +Required properties:
> > > +- compatible: should be "mxic,raw-nand-ctlr"
> >
> > I would prefer "macronix,nand-controller"
>
> okay, will patch it.
>
> >
> > > +- reg: should contain 1 entrie for the registers
> >
> > entry
> >
> > > +- reg-names: should contain "regs"
> >
> > Not sure you need that?
>
> for a base address of ctlr registers.

Yes I know, I mean: you don't necessarily need the 'reg-names' property
as it is supposed that the only entry will be the IP registers (unless
there are more). I don't know what's Rob preference here but I would
either drop the reg-names property or enhance the name, "regs" is
terribly not descriptive.

> > > +- interrupts: interrupt line connected to this NAND controller
> > > +- clock-names: should contain "ps_clk", "send_clk" and "send_dly_clk"
> > > +- clocks: should contain 3 entries for the "ps_clk", "send_clk" and
> > > + "send_dly_clk" clocks
> >
> > s/entries/phandles/ ?
>
> ?
> as I know that kernel views the phandle values as device tree structure
> information instead of device tree data and thus does not store them as
> properties.

The bindings have nothing to do with the kernel views. They might
actually be merged in a different project, out of the kernel.

Thanks,
Miquèl