From: Greg KH <gregkh@linuxfoundation.org>
To: Harsh Jain <harshjain32@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
harshjain.prof@gmail.com
Subject: Re: [PATCH] staging:kpc2000:Fix sparse warnings
Date: Fri, 28 Jun 2019 09:05:07 +0200 [thread overview]
Message-ID: <20190628070507.GA10932@kroah.com> (raw)
In-Reply-To: <20190627185138.26214-1-harshjain32@gmail.com>
On Fri, Jun 28, 2019 at 12:21:38AM +0530, Harsh Jain wrote:
> From: root <harshjain32@gmail.com>
Interesting user name :)
> Fix following sparse warning
> symbol was not declared. Should it be static?
> Using plain integer as NULL pointer
Don't do multiple things in the same patch. Please break thsi up into
two different patches and fix up your email address.
Also never do kernel development as root on your system, it's easy to
break things...
thanks,
greg k-h
prev parent reply other threads:[~2019-06-28 7:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 18:51 [PATCH] staging:kpc2000:Fix sparse warnings Harsh Jain
2019-06-28 7:05 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628070507.GA10932@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=harshjain.prof@gmail.com \
--cc=harshjain32@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox