[PATCH -next] nvme-pci: Make nvme_dev_pm_ops static

[PATCH -next] nvme-pci: Make nvme_dev_pm_ops static

[YueHaibing]

Fix sparse warning:

drivers/nvme/host/pci.c:2926:25: warning:
 symbol 'nvme_dev_pm_ops' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/nvme/host/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 1893520..f500133 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2923,7 +2923,7 @@ static int nvme_simple_resume(struct device *dev)
 	return 0;
 }
 
-const struct dev_pm_ops nvme_dev_pm_ops = {
+static const struct dev_pm_ops nvme_dev_pm_ops = {
 	.suspend	= nvme_suspend,
 	.resume		= nvme_resume,
 	.freeze		= nvme_simple_suspend,
-- 
2.7.4

Re: [PATCH -next] nvme-pci: Make nvme_dev_pm_ops static

[Minwoo Im]

On 19-06-26 10:09:02, YueHaibing wrote:
> Fix sparse warning:
> 
> drivers/nvme/host/pci.c:2926:25: warning:
>  symbol 'nvme_dev_pm_ops' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/nvme/host/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 1893520..f500133 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2923,7 +2923,7 @@ static int nvme_simple_resume(struct device *dev)
>  	return 0;
>  }
>  
> -const struct dev_pm_ops nvme_dev_pm_ops = {
> +static const struct dev_pm_ops nvme_dev_pm_ops = {
>  	.suspend	= nvme_suspend,
>  	.resume		= nvme_resume,
>  	.freeze		= nvme_simple_suspend,

IMHO, it should be in static.

Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>

Re: [PATCH -next] nvme-pci: Make nvme_dev_pm_ops static

[Chaitanya Kulkarni]

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

On 6/26/19, 1:23 PM, "Linux-nvme on behalf of Minwoo Im" <linux-nvme-bounces@lists.infradead.org on behalf of minwoo.im.dev@gmail.com> wrote:

    On 19-06-26 10:09:02, YueHaibing wrote:
    > Fix sparse warning:
    > 
    > drivers/nvme/host/pci.c:2926:25: warning:
    >  symbol 'nvme_dev_pm_ops' was not declared. Should it be static?
    > 
    > Reported-by: Hulk Robot <hulkci@huawei.com>
    > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    > ---
    >  drivers/nvme/host/pci.c | 2 +-
    >  1 file changed, 1 insertion(+), 1 deletion(-)
    > 
    > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
    > index 1893520..f500133 100644
    > --- a/drivers/nvme/host/pci.c
    > +++ b/drivers/nvme/host/pci.c
    > @@ -2923,7 +2923,7 @@ static int nvme_simple_resume(struct device *dev)
    >  	return 0;
    >  }
    >  
    > -const struct dev_pm_ops nvme_dev_pm_ops = {
    > +static const struct dev_pm_ops nvme_dev_pm_ops = {
    >  	.suspend	= nvme_suspend,
    >  	.resume		= nvme_resume,
    >  	.freeze		= nvme_simple_suspend,
    
    IMHO, it should be in static.
    
    Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
    
    _______________________________________________
    Linux-nvme mailing list
    Linux-nvme@lists.infradead.org
    http://lists.infradead.org/mailman/listinfo/linux-nvme
    

Re: [PATCH -next] nvme-pci: Make nvme_dev_pm_ops static

[Christoph Hellwig]

Thanks,

applied to nvme-5.3.