Re: [PATCH] i2c: remove casting dma_alloc

Wolfram Sang
2019-06-29T11:34:28Z

[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]

On Sun, Jun 23, 2019 at 11:13:53PM +0200, Vasyl Gomonovych wrote:
> From: Vasyl <gomonovych@gmail.com>
>
> Generated by: alloc_cast.cocci
>
> Signed-off-by: Vasyl <gomonovych@gmail.com>

Your other patches in git history have your full name. Why not this one?

@Jochen: are you still there, your ack would be very welcome.

> ---
> drivers/i2c/busses/i2c-cpm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c
> index 187900594e3d..1213e1932ccb 100644
> --- a/drivers/i2c/busses/i2c-cpm.c
> +++ b/drivers/i2c/busses/i2c-cpm.c
> @@ -531,7 +531,9 @@ static int cpm_i2c_setup(struct cpm_i2c *cpm)
> }
> out_be32(&rbdf[i].cbd_bufaddr, ((cpm->rxdma[i] + 1) & ~1));
>
> - cpm->txbuf[i] = (unsigned char *)dma_alloc_coherent(&cpm->ofdev->dev, CPM_MAX_READ + 1, &cpm->txdma[i], GFP_KERNEL);
> + cpm->txbuf[i] = dma_alloc_coherent(&cpm->ofdev->dev,
> + CPM_MAX_READ + 1,
> + &cpm->txdma[i], GFP_KERNEL);
> if (!cpm->txbuf[i]) {
> ret = -ENOMEM;
> goto out_muram;
> --
> 2.17.1