Re: [Freedreno] [PATCH 2/3] drm/msm/dpu: remove dpu_mdss:hwversion

Jordan Crouse
2019-07-11T18:47:36Z

On Sun, Jun 30, 2019 at 06:14:42AM -0700, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Unused and the extra rpm get/put interferes with handover from
> bootloader (ie. happens before we have a chance to check if
> things are already enabled).

Yay for not turning on the hardware before we need to.

Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>

> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
> index 986915bbbc02..e83dd4c6ec58 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
> @@ -22,7 +22,6 @@ struct dpu_mdss {
> struct msm_mdss base;
> void __iomem *mmio;
> unsigned long mmio_len;
> - u32 hwversion;
> struct dss_module_power mp;
> struct dpu_irq_controller irq_controller;
> struct icc_path *path[2];
> @@ -287,10 +286,6 @@ int dpu_mdss_init(struct drm_device *dev)
>
> dpu_mdss_icc_request_bw(priv->mdss);
>
> - pm_runtime_get_sync(dev->dev);
> - dpu_mdss->hwversion = readl_relaxed(dpu_mdss->mmio);
> - pm_runtime_put_sync(dev->dev);
> -
> return ret;
>
> irq_error:
> --
> 2.20.1
>
> _______________________________________________
> Freedreno mailing list
> Freedreno@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/freedreno

--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project