From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89523C0650E for ; Mon, 1 Jul 2019 07:53:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E2A720652 for ; Mon, 1 Jul 2019 07:53:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EKBIvdtp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727414AbfGAHw7 (ORCPT ); Mon, 1 Jul 2019 03:52:59 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:36181 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727010AbfGAHw7 (ORCPT ); Mon, 1 Jul 2019 03:52:59 -0400 Received: by mail-pg1-f195.google.com with SMTP id c13so5617610pgg.3; Mon, 01 Jul 2019 00:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rdcIi2cumO41Y4zgqEx+RI7IBrTExhB5mGxaS338vMg=; b=EKBIvdtpU4JjTSu+btioEx6SVuPsS2YcCGeGEzSHD8Mqpbt3QjFzV01J0HGdAsZMxA miNJP3pvKvK5Vv+QBePJUFMAkF288+oNkNeqoj4C/DTPSCZQdZjVWd0S6PUHXogRcXUA LkI1bUyYnk4xpBuAeWcTqic5UQ5H/XSi+WrjJofVuO+MJwUy7qq5bH2UnIZDLsheczc/ X2ynD5HruKB9PzJ8PJTO4+YJymag+fizsW1DpLODc4NNbZ/dfa3eAbp56Yy9ogNwHlIV UE7clsbPccJZVbnCX4wiWFeH+PNqnTE4xtfPm/R6metV6iITyl/Gz0sBO8kHFuSdzR0V VhMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rdcIi2cumO41Y4zgqEx+RI7IBrTExhB5mGxaS338vMg=; b=kx6g0YwVHg+9vNJA+409opAoIaSyateStgrqgQgLiGOEOiZsW6MP5TSQu7u0mYiTZ1 myal7tgHJBjqR/9lNjfX9GDGpYf3zSPuIdmReDJ+gZY4R0bklVrQuNhAp1j4F/544gan nOf7Zl5kj8VWEVfI7d9Wi7GmLeFBQ66K8vZ2ecjJ6gklBnVAy/AhdUhMVW4PYia2v/k4 JRcbZjgJIE0yQusr9u6UjEbfs3SnwpCyEmsXGi4B65tjB6dHS+7OCkIcp8c90Qe+nIo4 /aCX9O/u4Qmg/FabF0tndgWs+i1XmYca/syKUSu4aePFzimtJChEbUjFPlHM9L/Br5vH 7muQ== X-Gm-Message-State: APjAAAX0Z6XUSxmlbOvSxn5/1xujZ+XUqzVJ7JvuJBCd4ZT1b9tvKOen tGwHMKDXiNybqh6Mb9ncW7E= X-Google-Smtp-Source: APXvYqz+5OQaUvqEiswzedP1HrM6edG/iaiLW0IB1Z0Zqu6vyMD+jY20kS9fCmT0tw3iTMQujMtKbQ== X-Received: by 2002:a17:90a:3585:: with SMTP id r5mr30793616pjb.15.1561967578351; Mon, 01 Jul 2019 00:52:58 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id t96sm8530996pjb.1.2019.07.01.00.52.57 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 01 Jul 2019 00:52:57 -0700 (PDT) Date: Mon, 1 Jul 2019 00:52:55 -0700 From: Dmitry Torokhov To: Fuqian Huang Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Sylvain Lemieux , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Olof Johansson , H Hartley Sweeten , Arnd Bergmann , Enrico Weigelt , Thomas Gleixner , Andy Shevchenko , Kate Stewart , Florian Fainelli , Anson Huang , Richard Fontana , Greg Kroah-Hartman , Allison Randal , Christian Hoff , Tony Lindgren , Alexios Zavras , Gabriel Fernandez , Luca Weiss , Rob Herring , Dan Carpenter , Brian Masney , Lee Jones , Pascal PAILLET-LME , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 2/4] input: keyboard/mouse/touchscreen/misc: Use dev_get_drvdata() Message-ID: <20190701075255.GD172968@dtor-ws> References: <20190701032342.25971-1-huangfq.daxian@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190701032342.25971-1-huangfq.daxian@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fuqian, On Mon, Jul 01, 2019 at 11:23:12AM +0800, Fuqian Huang wrote: > Using dev_get_drvdata directly. > I prefer using proper bus accessors. Thanks. -- Dmitry