From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE32CC06510 for ; Mon, 1 Jul 2019 16:03:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8EFB21473 for ; Mon, 1 Jul 2019 16:03:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="aOPoFzu5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730254AbfGAQDQ (ORCPT ); Mon, 1 Jul 2019 12:03:16 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46012 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727419AbfGAQDQ (ORCPT ); Mon, 1 Jul 2019 12:03:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IetNNsaoWLkYSAXHE+XLJKKaYo2maSqrxawr9i3AODM=; b=aOPoFzu5X7DIXa6UoMwgiG7W4O dEG+8mePAq/q1GKJV5ij276Gar/vIfjp5D6Gn+ilv3X7r4mITYTQBKzBmDCOqmazbSVrCZpM0Rgfu bD1AXorJAWLUU/UpxuflwHXIkXlpVBNaXiBRvzQzEL8HCGlLZCOkd1UZFV2oAk/bcK/Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hhylr-0008CQ-5d; Mon, 01 Jul 2019 18:03:11 +0200 Date: Mon, 1 Jul 2019 18:03:11 +0200 From: Andrew Lunn To: Pawel Dembicki Cc: linus.walleij@linaro.org, Vivien Didelot , Florian Fainelli , "David S. Miller" , Rob Herring , Mark Rutland , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] net: dsa: vsc73xx: Split vsc73xx driver Message-ID: <20190701160311.GB30468@lunn.ch> References: <20190701152723.624-1-paweldembicki@gmail.com> <20190701152723.624-2-paweldembicki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190701152723.624-2-paweldembicki@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -495,12 +380,12 @@ static int vsc73xx_update_bits(struct vsc73xx *vsc, u8 block, u8 subblock, > int ret; > > /* Same read-modify-write algorithm as e.g. regmap */ > - ret = vsc73xx_read(vsc, block, subblock, reg, &orig); > + ret = vsc->ops->read(vsc, block, subblock, reg, &orig); > if (ret) > return ret; > tmp = orig & ~mask; > tmp |= val & mask; > - return vsc73xx_write(vsc, block, subblock, reg, tmp); > + return vsc->ops->write(vsc, block, subblock, reg, tmp); This patch would be a lot less invasive and smaller if you hid the difference between SPI and platform inside vsc73xx_write() and vsc73xx_read(). > -static int vsc73xx_probe(struct spi_device *spi) > +int vsc73xx_probe(struct vsc73xx *vsc) > { > - struct device *dev = &spi->dev; struct device *dev = vsc->dev; and then a lot of the changes you make here go away. In general, think about how to make the changes small. It saves your time from actually making changes, and reviewer time since the patch it smaller. Andrew