Re: [PATCH 4.14 43/43] tipc: pass tunnel dev as NULL to udp_tunnel(6)_xmit_skb

gregkh
2019-08-03T07:11:05Z

On Sat, Aug 03, 2019 at 08:45:03AM +0800, Xin Long wrote:
> On Fri, Aug 2, 2019 at 7:03 PM Rantala, Tommi T. (Nokia - FI/Espoo)
> <tommi.t.rantala@nokia.com> wrote:
> >
> > On Fri, 2019-08-02 at 09:28 +0200, gregkh@linuxfoundation.org wrote:
> > > On Thu, Aug 01, 2019 at 10:17:30AM +0000, Rantala, Tommi T. (Nokia -
> > > FI/Espoo) wrote:
> > > > Hi,
> > > >
> > > > This tipc patch added in 4.14.132 is triggering a crash for me,
> > > > revert
> > > > fixes it.
> > > >
> > > > Anyone have ideas if some other commits missing in 4.14.x to make
> > > > this
> > > > work...?
> > >
> > > Do you also hav a problem with 4.19.y? How about 5.2.y? If not, can
> > > you do 'git bisect' to find the patch that fixes the issue?
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Hi, please pick this to 4.14.y and 4.19.y, tested that it fixes the
> > crash in both:
> >
> > commit 5684abf7020dfc5f0b6ba1d68eda3663871fce52
> > Author: Xin Long <lucien.xin@gmail.com>
> > Date: Mon Jun 17 21:34:13 2019 +0800
> >
> > ip_tunnel: allow not to count pkts on tstats by setting skb's dev
> > to NULL
> Thanks Rantala,
>
> sorry for late, I was in a trip.
>
> The patch belongs to a patchset:
>
> https://www.spinics.net/lists/netdev/msg578674.html
>
> So this commit should also be included:
>
> commit 6f6a8622057c92408930c31698394fae1557b188
> Author: Xin Long <lucien.xin@gmail.com>
> Date: Mon Jun 17 21:34:14 2019 +0800
>
> ip6_tunnel: allow not to count pkts on tstats by passing dev as NULL

This commit is also included in the following kernel releases:
4.9.186 4.14.134 4.19.59 5.1.18 5.2

so this should all be taken care of, right?

If not, please let me know.

thanks,

greg k-h