From: Christoph Hellwig <hch@lst.de>
To: Marta Rybczynska <mrybczyn@kalray.eu>
Cc: Hannes Reinecke <hare@suse.de>, kbusch <kbusch@kernel.org>,
axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme <linux-nvme@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Samuel Jones <sjones@kalray.eu>,
Jean-Baptiste Riaux <jbriaux@kalray.eu>
Subject: Re: [PATCH] nvme: fix multipath crash when ANA deactivated
Date: Tue, 2 Jul 2019 16:25:33 +0200 [thread overview]
Message-ID: <20190702142533.GA16763@lst.de> (raw)
In-Reply-To: <1229162251.30096937.1562061155630.JavaMail.zimbra@kalray.eu>
On Tue, Jul 02, 2019 at 11:52:35AM +0200, Marta Rybczynska wrote:
> > They idea was to use a 'ana_log_buf == NULL' as an indicator that ANA is
> > disabled, so there is no need to have an additional flag.
>
> OK, still keeping the split of the helper functions?
I think we can simplify switch nvme_ctrl_use_ana to only check for
->ana_log_buf, and just opencode the actual capabilities check in
the setup path.
prev parent reply other threads:[~2019-07-02 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 10:10 [PATCH] nvme: fix multipath crash when ANA deactivated Marta Rybczynska
2019-07-02 9:31 ` Hannes Reinecke
2019-07-02 9:52 ` Marta Rybczynska
2019-07-02 14:25 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702142533.GA16763@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=hare@suse.de \
--cc=jbriaux@kalray.eu \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mrybczyn@kalray.eu \
--cc=sagi@grimberg.me \
--cc=sjones@kalray.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox