From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E335C5B57D for ; Wed, 3 Jul 2019 02:18:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 510122189E for ; Wed, 3 Jul 2019 02:18:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562120302; bh=5H906uRkLsp9h23SbnZEAf41XmBJLvnlTnIbGpZBXMc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=KFj+YIfRaazBGIWtgBluFbmykzEyXa3HXcj7n7RqXGDNGkiUp582ggAzPx/sFcLY6 Eh09g23knJFhGMbeyRprjQpmzOTaKifC6i4kMzC90f9NBRBuUKlflEaJGbz07GXHlS zMkVAP+so6hwNDtRp2VTAkX4pvDBNyxke2YZRqaU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728245AbfGCCSV (ORCPT ); Tue, 2 Jul 2019 22:18:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:56222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728004AbfGCCSS (ORCPT ); Tue, 2 Jul 2019 22:18:18 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A509821874; Wed, 3 Jul 2019 02:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562120297; bh=5H906uRkLsp9h23SbnZEAf41XmBJLvnlTnIbGpZBXMc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hphMU/1GtREF6aQTSsxZiwPF1HT2m3CVD7O7nKhi+Vq0Uqur+QU37CptIYWnqmxBH Gs5qY03NMbI2RQUWj0gFa1QbbfT2MMcp3WEcgkme3ldxR0ropi/3lXWlv12QBVZqBZ jUNrlUrh19YonwIO/sQtLYe3OfK4NwA6cPQ6CXSs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hans de Goede , Ard Biesheuvel , Sasha Levin , linux-efi@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 02/13] efi/bgrt: Drop BGRT status field reserved bits check Date: Tue, 2 Jul 2019 22:18:03 -0400 Message-Id: <20190703021814.18385-2-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190703021814.18385-1-sashal@kernel.org> References: <20190703021814.18385-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans de Goede [ Upstream commit a483fcab38b43fb34a7f12ab1daadd3907f150e2 ] Starting with ACPI 6.2 bits 1 and 2 of the BGRT status field are no longer reserved. These bits are now used to indicate if the image needs to be rotated before being displayed. The first device using these bits has now shown up (the GPD MicroPC) and the reserved bits check causes us to reject the valid BGRT table on this device. Rather then changing the reserved bits check, allowing only the 2 new bits, instead just completely remove it so that we do not end up with a similar problem when more bits are added in the future. Signed-off-by: Hans de Goede Signed-off-by: Ard Biesheuvel Signed-off-by: Sasha Levin --- drivers/firmware/efi/efi-bgrt.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/firmware/efi/efi-bgrt.c b/drivers/firmware/efi/efi-bgrt.c index 50793fda7819..e3d86aa1ad5d 100644 --- a/drivers/firmware/efi/efi-bgrt.c +++ b/drivers/firmware/efi/efi-bgrt.c @@ -50,11 +50,6 @@ void __init efi_bgrt_init(struct acpi_table_header *table) bgrt->version); goto out; } - if (bgrt->status & 0xfe) { - pr_notice("Ignoring BGRT: reserved status bits are non-zero %u\n", - bgrt->status); - goto out; - } if (bgrt->image_type != 0) { pr_notice("Ignoring BGRT: invalid image type %u (expected 0)\n", bgrt->image_type); -- 2.20.1