From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC981C5B57D for ; Wed, 3 Jul 2019 03:29:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 878A1218BC for ; Wed, 3 Jul 2019 03:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562124544; bh=q6NPunlPl7glSalNJqR89+RniPP3z8aacYYQpG8ejiQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=S7klXYOFFOqT3o7YovEgUoRRxcpXXKMNhujjfP6NcX9GTPPbStLK5+oXaIfynpkS4 8ooyAVyYsaCGK4Q3YkUsW72u0xDgJr0cIba+s0kiEEcDw1Bc3g5CAksI3aHkxQOrdE kLcFeVPiv7MO3jtPYuh8m/gPKR43EYCZvabeGzXQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727556AbfGCD3D (ORCPT ); Tue, 2 Jul 2019 23:29:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:57110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727537AbfGCD25 (ORCPT ); Tue, 2 Jul 2019 23:28:57 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.35.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 56F5B21871; Wed, 3 Jul 2019 03:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562124536; bh=q6NPunlPl7glSalNJqR89+RniPP3z8aacYYQpG8ejiQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pZUiDS2V6b3qZHEpqRCF1nb79sbRgFe2WltMj9+LkWJaOm5IYXLDrkNrjBDZH2aCa lQGkKAFBIjk7WcS6ribzepB5229DnPYtEv+Jt0/jmHsJafAWxvkIJ/kR6orTC4vdU3 5hzb3lBPCGZApvb4xlKmWDec35oorVyOPQrCuol4= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andi Kleen , Arnaldo Carvalho de Melo Subject: [PATCH 15/18] perf list: Avoid extra : for --raw metrics Date: Wed, 3 Jul 2019 00:27:43 -0300 Message-Id: <20190703032746.21692-16-acme@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190703032746.21692-1-acme@kernel.org> References: <20190703032746.21692-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen When printing the metrics raw, don't print : after the metricgroups. This helps the command line completion to complete those too. Signed-off-by: Andi Kleen Cc: Jiri Olsa Link: http://lkml.kernel.org/r/20190628220737.13259-2-andi@firstfloor.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/metricgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c index bc25995255ab..7d36435fa84c 100644 --- a/tools/perf/util/metricgroup.c +++ b/tools/perf/util/metricgroup.c @@ -375,7 +375,7 @@ void metricgroup__print(bool metrics, bool metricgroups, char *filter, struct mep *me = container_of(node, struct mep, nd); if (metricgroups) - printf("%s%s%s", me->name, metrics ? ":" : "", raw ? " " : "\n"); + printf("%s%s%s", me->name, metrics && !raw ? ":" : "", raw ? " " : "\n"); if (metrics) metricgroup__print_strlist(me->metrics, raw); next = rb_next(node); -- 2.20.1