From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D0CDC5B578 for ; Wed, 3 Jul 2019 06:17:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7147921881 for ; Wed, 3 Jul 2019 06:17:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JKwTiDBL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727142AbfGCGRv (ORCPT ); Wed, 3 Jul 2019 02:17:51 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:33949 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726201AbfGCGRu (ORCPT ); Wed, 3 Jul 2019 02:17:50 -0400 Received: by mail-wr1-f68.google.com with SMTP id u18so1286353wru.1 for ; Tue, 02 Jul 2019 23:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=+b+ZNE8muQpXOkikX4gDxD4noa9WUcqsJTLAj8ORuJM=; b=JKwTiDBL2F+xPIXodfp3SDz4pvAQOhkw28XjDRRIIYEZDf0uHXJ1kaleuATAaqGLSj /lUVb0laNogltshs0CJYJM/yRK5yRpb7G7aiJv4OhPU4LA7450Dc2/qnaeiyRbXcW6sU nm0PusQqZCpWiHtb9fRFRri5N45uAQ3MzhWMu9l+CFg/k5JUiRkPVLg+Nqw8/WwRE2A8 lGEnGR1X1u/hGIzOEXy2X1Ud6SvgllAo5AV9pnp0rHC2lFF7dZez2Of7YCaciwEvGILQ iI+ghMdv9+1ejKc7ydDrAXaUhi/ErjFpwMBtxxQXrETNf0ebq/cu896eshbhURPsvkcR gcqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=+b+ZNE8muQpXOkikX4gDxD4noa9WUcqsJTLAj8ORuJM=; b=N7LAJl0FvVqkcOsZrnXmsg4DH/J7PCOk8iALD5eF2KisYrj5+ETx2MF9UoiBt+Tn5y D7VE854QZmgMliHYLfA4DLKKB8p14GldUbZ5ItvCKGUZ9SIEAIPyhqoqfRpnCyFtvCOy R9xj3nlbFQdwZiwWFWJgJ63JnQaYL0B7f4BRrZ1obAl80CWxtVlmPl50YuQRfgT/fFKW XQjnBqJ//od6/ZN6x5RVTOqbxJlTJzmXyyPth8Z94f2wXvoTo9lnZr9k8t5qKLuK0tdI ktPikPlmz8qB1S8H2s+7RLp//TOPIzeWqJLYi1TmI2qJdIwZH5wcSAqFg/THdtbdqe2a f3ZA== X-Gm-Message-State: APjAAAWGkPbi4SJxUFixz4xRMVgy93lq3Hf1VOqlGhEHqGjXx9MLGvhR IqpqW00e6Cf56m/TUrvfXK870Q== X-Google-Smtp-Source: APXvYqz+4yF7FL0ZwdGQ6A6cFS0uz4zTCMWbnntXpvljfOHA2f6i0BKfL5+UQZ2+UhOOhD69RM5yiA== X-Received: by 2002:a5d:494d:: with SMTP id r13mr28538311wrs.152.1562134669005; Tue, 02 Jul 2019 23:17:49 -0700 (PDT) Received: from dell ([2.27.35.164]) by smtp.gmail.com with ESMTPSA id c1sm1572121wrh.1.2019.07.02.23.17.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Jul 2019 23:17:48 -0700 (PDT) Date: Wed, 3 Jul 2019 07:17:46 +0100 From: Lee Jones To: Lothar =?iso-8859-1?Q?Wa=DFmann?= Cc: Fuqian Huang , Andy Shevchenko , Kate Stewart , Tony Lindgren , Richard Fontana , Laxman Dewangan , Fabio Estevam , Rob Herring , Florian Fainelli , Anson Huang , Jonathan Hunter , Luca Weiss , NXP Linux Team , Sylvain Lemieux , Dan Carpenter , Brian Masney , Arnd Bergmann , Sascha Hauer , linux-input , Vladimir Zapolskiy , Alexios Zavras , linux-tegra@vger.kernel.org, Thomas Gleixner , Andy Shevchenko , Allison Randal , linux-arm Mailing List , Pascal PAILLET-LME , Shawn Guo , Dmitry Torokhov , Linux Kernel Mailing List , H Hartley Sweeten , Thierry Reding , Pengutronix Kernel Team , Greg Kroah-Hartman , Olof Johansson , Christian Hoff , Enrico Weigelt , Gabriel Fernandez Subject: Re: [PATCH 2/4] input: keyboard/mouse/touchscreen/misc: Use dev_get_drvdata() Message-ID: <20190703061746.GI4652@dell> References: <20190701032342.25971-1-huangfq.daxian@gmail.com> <20190701075255.GD172968@dtor-ws> <20190702143225.12b0fe07@karo-electronics.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190702143225.12b0fe07@karo-electronics.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 02 Jul 2019, Lothar Waßmann wrote: > Hi, > > On Tue, 2 Jul 2019 19:47:16 +0800 Fuqian Huang wrote: > > Andy Shevchenko 於 2019年7月2日週二 下午5:51寫道： > > > > > > On Tue, Jul 2, 2019 at 11:20 AM Fuqian Huang wrote: > > > > > > > > I am not an expert on this. I just write a coccinelle script to search > > > > this kind of misuse and fix it in a naive way. > > > > Could you tell me about how to use the proper bus accessors? Then I > > > > will fix it up and resend a v2 patch set. > > > > > > First, don't top post. > > > And answering to this, simple drop the patch. > > > Proper bus accessors is exactly what it's used in the current code. > > > > But why not use dev_get_drvdata directly. > > It simplifies getting the 'driver_data' from 'struct device' directly. > > And the platform_device here is not required. > > Replace it can remove the unnecessary step back and forth. (dev -> pdev -> dev). > > > Did you check whether the compiler generates different (better) code > with and without your patch? My guess is it won't. I can see Fuqian's point. If bus APIs are preferred, maybe it would be nicer if the function was adapted to accept a platform_device instead? Caveat: I haven't taken the time to look into the call-site details. This comment is based on just the patch alone. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog