From: Miles Chen <miles.chen@mediatek.com>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <wsd_upstream@mediatek.com>,
Miles Chen <miles.chen@mediatek.com>
Subject: [PATCH] checkpatch: avoid default n
Date: Wed, 3 Jul 2019 16:30:31 +0800 [thread overview]
Message-ID: <20190703083031.2950-1-miles.chen@mediatek.com> (raw)
This change reports a warning when "default n" is used.
I have seen several "remove default n" patches, so I think
it might be helpful to add this test in checkpatch.
tested:
WARNING: 'default n' is the default value, no need to write it explicitly.
+ default n
Signed-off-by: Miles Chen <miles.chen@mediatek.com>
---
scripts/checkpatch.pl | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 342c7c781ba5..6531b5757c6b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3005,6 +3005,13 @@ sub process {
"Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
}
+# avoid redundant 'default n'
+ if ($realfile =~ /Kconfig/ &&
+ $line =~ /^\+\s*\bdefault n\b/) {
+ WARN("AVOID_DEFAULT_N",
+ "'default n' is the default value, no need to write it explicitly.\n" . $herecurr);
+ }
+
if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
my $flag = $1;
--
2.18.0
next reply other threads:[~2019-07-03 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 8:30 Miles Chen [this message]
2019-07-03 8:42 ` [PATCH] checkpatch: avoid default n Joe Perches
2019-07-03 8:58 ` Yingjoe Chen
2019-07-03 9:03 ` Yingjoe Chen
2019-07-03 15:37 ` Joe Perches
2019-07-04 5:48 ` Miles Chen
2019-07-03 11:22 ` Miles Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703083031.2950-1-miles.chen@mediatek.com \
--to=miles.chen@mediatek.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox