From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C0A4C06511 for ; Wed, 3 Jul 2019 00:28:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA49A21E6C for ; Wed, 3 Jul 2019 00:28:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562113687; bh=pPxcb0LDsgQA0SUglccwz7TppfnSPAMhkWwUGPg2n/U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=uxaYrMs269MgmPVXtlaKFaYrlADvDN5KR12EUgNglCoDhmHnJiLYgJKDsXZyviGdI sgzITGO+Ody71ydcRKchgTSoz34N0UJGjaUvPUPTh2ibZfz8DbiXlIzA0Mm/wM5PjY FZfgDmtFLpXtWVibznNK5PKvlOMvBZv5MNnMCdC8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727221AbfGCA2G (ORCPT ); Tue, 2 Jul 2019 20:28:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:37592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbfGCA2F (ORCPT ); Tue, 2 Jul 2019 20:28:05 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 655FE219BE; Wed, 3 Jul 2019 00:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562112712; bh=pPxcb0LDsgQA0SUglccwz7TppfnSPAMhkWwUGPg2n/U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=i3OgV8IoDaCpBBFL4wfhTmqEmtyTbGAjNPUyQsefF5sUYp/p2urm59EVpDNvfU0hf P5wWdvdoehBE4sUVrqsQKWu3MUGz4xk+f2cM4OSq5b6JOHsHcJnUgIr1WGGmuLnlE6 mGtWW9nT/7F0F1Nn6YiNZFmqkbUCIKPVghmxf6NY= Date: Wed, 3 Jul 2019 09:11:47 +0900 From: Masami Hiramatsu To: shuah Cc: Po-Hsu Lin , rostedt@goodmis.org, mingo@redhat.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/ftrace: skip ftrace test if FTRACE was not enabled Message-Id: <20190703091147.064029248fed5066ea5e5d2b@kernel.org> In-Reply-To: <4a44dd22-be88-ce5b-5c9b-6a3759b6c2eb@kernel.org> References: <20190702062358.7330-1-po-hsu.lin@canonical.com> <4a44dd22-be88-ce5b-5c9b-6a3759b6c2eb@kernel.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Po-Hsu Lin, On Tue, 2 Jul 2019 13:22:26 -0600 shuah wrote: > Hi Po-Hsu Lin, > > On 7/2/19 12:23 AM, Po-Hsu Lin wrote: > > The ftrace test will need to have CONFIG_FTRACE enabled to make the > > ftrace directory available. > > > > Add an additional check to skip this test if the CONFIG_FTRACE was not > > enabled. Sorry, NAK for config check. > > > > This will be helpful to avoid a false-positive test result when testing > > it directly with the following commad against a kernel that does not > > have CONFIG_FTRACE enabled: Would you know tools/testing/selftests/ftrace/config (and other config files in each tests) ? Since each selftest depends specific configurations, those configs are written in config file, and tester must enable it using "scripts/kconfig/merge_config.sh". We can not check the kernel config in some cases, e.g. distro kernel, cross-build kernel, remote build kernel etc. Also, the .config file can be a config file for another kernel build. So please take care of your kernel configuration. If you find any test failed even if you enable configs in config file under that test, please report it, since that is a bug. Thank you, > > make -C tools/testing/selftests TARGETS=ftrace run_tests > > > > The test result on an Ubuntu KVM kernel will be changed from: > > selftests: ftrace: ftracetest > > ======================================== > > Error: No ftrace directory found > > not ok 1..1 selftests: ftrace: ftracetest [FAIL] > > To: > > Thanks for the patch. > > Check patch fails with the above To: > > WARNING: Use a single space after To: > #107: > To: > > ERROR: Unrecognized email address: '' > #107: > To: > > total: 1 errors, 1 warnings, 23 lines checked > > > Please fix and send v2. > > > selftests: ftrace: ftracetest > > ======================================== > > CONFIG_FTRACE was not enabled, test skipped. > > not ok 1..1 selftests: ftrace: ftracetest [SKIP] > > > > Signed-off-by: Po-Hsu Lin > > --- > > tools/testing/selftests/ftrace/ftracetest | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest > > index 6d5e9e8..6c8322e 100755 > > --- a/tools/testing/selftests/ftrace/ftracetest > > +++ b/tools/testing/selftests/ftrace/ftracetest > > @@ -7,6 +7,9 @@ > > # Written by Masami Hiramatsu > > # > > Hmm. You havem't cc'ed Masami on this. Adding Masami. > > I would think Masami should be on the Signed-off-by as well, > since he is the author. > > > > > +# Kselftest framework requirement - SKIP code is 4. > > +ksft_skip=4 > > + > > usage() { # errno [message] > > [ ! -z "$2" ] && echo $2 > > echo "Usage: ftracetest [options] [testcase(s)] [testcase-directory(s)]" > > @@ -139,7 +142,13 @@ parse_opts $* > > > > # Verify parameters > > if [ -z "$TRACING_DIR" -o ! -d "$TRACING_DIR" ]; then > > - errexit "No ftrace directory found" > > + ftrace_enabled=`grep "^CONFIG_FTRACE=y" /lib/modules/$(uname -r)/build/.config` > > + if [ -z "$ftrace_enabled" ]; then > > + echo "CONFIG_FTRACE was not enabled, test skipped." > > + exit $ksft_skip > > + else > > + errexit "No ftrace directory found" > > + fi > > fi > > > > # Preparing logs > > > > thanks, > -- Shuah -- Masami Hiramatsu