From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 886FDC0650E for ; Wed, 3 Jul 2019 09:32:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 582C6218A4 for ; Wed, 3 Jul 2019 09:32:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562146358; bh=/RwaPAWA1DPbaIvaC/1DWInwxGABHiJMN8vj2aVluVs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=B6GmLFHNGwx7+IlJGZk6WF/da0k7oOKoNa2mgGmUuv21Hlo0vpssox6w3tAabRBjS mVhJ8I5FA0NauWLrFFnVRe610EykW/9a6cZt0mi7F+lLX2Qw+oHVvb1JoJcvFjwsiX hU8evAxA8osPfTkQh6EWR5Td5XyHziffAKIiH5B0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726871AbfGCJch (ORCPT ); Wed, 3 Jul 2019 05:32:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:37510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726305AbfGCJcg (ORCPT ); Wed, 3 Jul 2019 05:32:36 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A3FF621882; Wed, 3 Jul 2019 09:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562146356; bh=/RwaPAWA1DPbaIvaC/1DWInwxGABHiJMN8vj2aVluVs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nLcwCpjtjrmN2iIi0b3VJSuTdHpFAmZe3uAd5iPy1jLzlTkJRh/TUBeoIBbwjFPXi 9c6tWxoxjdqyDV7AyDHnyy4F4v9ncZP/XcvQzBw5thnB+PRE966VxZXu1ZVOw0R4Kv xOqLvKJ7tDtpu9WVJEYCOsk3WkvhywEXzkmOlfPE= Date: Wed, 3 Jul 2019 11:32:33 +0200 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Cc: Mark Brown , Takashi Iwai , Linux Kernel Mailing List Subject: Re: [PATCH 2/2] debugfs: log errors when something goes wrong Message-ID: <20190703093233.GA4436@kroah.com> References: <20190703071653.2799-1-gregkh@linuxfoundation.org> <20190703071653.2799-2-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 03, 2019 at 11:10:44AM +0200, Rafael J. Wysocki wrote: > On Wed, Jul 3, 2019 at 9:17 AM Greg Kroah-Hartman > wrote: > > > > As it is not recommended that debugfs calls be checked, it was pointed > > out that major errors should still be logged somewhere so that > > developers and users have a chance to figure out what went wrong. To > > help with this, error logging has been added to the debugfs core so that > > it is not needed to be present in every individual file that calls > > debugfs. > > > > Reported-by: Mark Brown > > Reported-by: Takashi Iwai > > Cc: "Rafael J. Wysocki" > > Signed-off-by: Greg Kroah-Hartman > > Generally speaking > > Reviewed-by: Rafael J. Wysocki > > > --- > > fs/debugfs/inode.c | 25 ++++++++++++++++++++----- > > 1 file changed, 20 insertions(+), 5 deletions(-) > > > > diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c > > index f04c8475d9a1..7f43c8acfcbf 100644 > > --- a/fs/debugfs/inode.c > > +++ b/fs/debugfs/inode.c > > @@ -2,8 +2,9 @@ > > /* > > * inode.c - part of debugfs, a tiny little debug file system > > * > > - * Copyright (C) 2004 Greg Kroah-Hartman > > + * Copyright (C) 2004,2019 Greg Kroah-Hartman > > * Copyright (C) 2004 IBM Inc. > > + * Copyright (C) 2019 Linux Foundation > > * > > * debugfs is for people to use instead of /proc or /sys. > > * See ./Documentation/core-api/kernel-api.rst for more details. > > @@ -294,8 +295,10 @@ static struct dentry *start_creating(const char *name, struct dentry *parent) > > > > error = simple_pin_fs(&debug_fs_type, &debugfs_mount, > > &debugfs_mount_count); > > - if (error) > > + if (error) { > > + pr_err("Unable to pin filesystem for file '%s'\n", name); > > But I'm not sure about the log level here. Particularly, why would > pr_info() not work? It could, but it is an error in that debugfs didn't do what was asked of it. I really don't care either way, the odds of anyone ever seeing this message is almost none :) thanks, greg k-h