Re: [PATCH 01/25] arm64: dts: allwinner: Switch A64 dts(i) to use SPDX identifier

Maxime Ripard
2019-07-03T13:28:45Z

[-- Attachment #1: Type: text/plain, Size: 2454 bytes --]

On Wed, Jul 03, 2019 at 06:15:45PM +0530, Jagan Teki wrote:
> Adopt the SPDX license identifier headers to ease license
> compliance management on Allwinner A64 dts(i) files.
>
> While the text specifies "of the GPL or the X11 license"
> but the actual license text matches the MIT license as
> specified at [0]
>
> [0] https://spdx.org/licenses/MIT.html
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 39 +------------------
> .../dts/allwinner/sun50i-a64-nanopi-a64.dts | 39 +------------------
> .../dts/allwinner/sun50i-a64-olinuxino.dts | 39 +------------------
> .../dts/allwinner/sun50i-a64-orangepi-win.dts | 39 +------------------
> .../dts/allwinner/sun50i-a64-pine64-plus.dts | 39 +------------------
> .../boot/dts/allwinner/sun50i-a64-pine64.dts | 39 +------------------
> .../allwinner/sun50i-a64-sopine-baseboard.dts | 39 +------------------
> .../boot/dts/allwinner/sun50i-a64-sopine.dtsi | 39 +------------------
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 39 +------------------
> 9 files changed, 9 insertions(+), 342 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> index 208373efee49..efdd84c362b0 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> @@ -1,43 +1,6 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)

You say that this is a GPL2 only license

> /*
> * Copyright (c) 2016 ARM Ltd.
> - *
> - * This file is dual-licensed: you can use it either under the terms
> - * of the GPL or the X11 license, at your option. Note that this dual
> - * licensing only applies to this file, and not this project as a
> - * whole.
> - *
> - * a) This library is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License as
> - * published by the Free Software Foundation; either version 2 of the
> - * License, or (at your option) any later version.

While this is GPL2 or later.

Also, I'm not sure why we need 25 patches to do that. Can't you just
send one (there's no even need to separate arm and arm64, since we
will do only a single PR from now as opposed to what we were doing
before).

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]