From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5545FC0650E for ; Wed, 3 Jul 2019 14:05:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2868B218B0 for ; Wed, 3 Jul 2019 14:05:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="SnKFE7+Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727116AbfGCOF2 (ORCPT ); Wed, 3 Jul 2019 10:05:28 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51204 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727079AbfGCOF1 (ORCPT ); Wed, 3 Jul 2019 10:05:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ocBZZm2C0AqTeZY6iNexdtzLdOjyd9FHHH3bSX7zaec=; b=SnKFE7+Zlhm90oZGy2bd5UIeuU ZsmnkDOgJtBzYEu9NLHTb2eZj794oqlnrJAvCTWhFxVIy7cGt80hhKjSVF03oDW7AEid1qGF0PJZg 555lSSrP7JQlP+6gQekUzsztjjpaX3SHcO56tpSzNNpluDZ2AqndwA1qaLIOUHl8BVtM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hifsu-0004uU-MQ; Wed, 03 Jul 2019 16:05:20 +0200 Date: Wed, 3 Jul 2019 16:05:20 +0200 From: Andrew Lunn To: Voon Weifeng Cc: "David S. Miller" , Maxime Coquelin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jose Abreu , Giuseppe Cavallaro , Florian Fainelli , Alexandre Torgue , biao huang , Ong Boon Leong , Kweh Hock Leong Subject: Re: [PATCH v1 net-next] net: stmmac: enable clause 45 mdio support Message-ID: <20190703140520.GA18473@lunn.ch> References: <1562147404-4371-1-git-send-email-weifeng.voon@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1562147404-4371-1-git-send-email-weifeng.voon@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 03, 2019 at 05:50:04PM +0800, Voon Weifeng wrote: > @@ -155,22 +171,26 @@ static int stmmac_mdio_read(struct mii_bus *bus, int phyaddr, int phyreg) > struct stmmac_priv *priv = netdev_priv(ndev); > unsigned int mii_address = priv->hw->mii.addr; > unsigned int mii_data = priv->hw->mii.data; > - u32 v; > - int data; > u32 value = MII_BUSY; > + int data = 0; > + u32 v; > > value |= (phyaddr << priv->hw->mii.addr_shift) > & priv->hw->mii.addr_mask; > value |= (phyreg << priv->hw->mii.reg_shift) & priv->hw->mii.reg_mask; > value |= (priv->clk_csr << priv->hw->mii.clk_csr_shift) > & priv->hw->mii.clk_csr_mask; > - if (priv->plat->has_gmac4) > + if (priv->plat->has_gmac4) { > value |= MII_GMAC4_READ; > + if (phyreg & MII_ADDR_C45) > + stmmac_mdio_c45_setup(priv, phyreg, &value, &data); > + } > > if (readl_poll_timeout(priv->ioaddr + mii_address, v, !(v & MII_BUSY), > 100, 10000)) > return -EBUSY; > > + writel(data, priv->ioaddr + mii_data); That looks odd. Could you explain why it is needed. Thanks Andrew