From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 408B0C0650E for ; Wed, 3 Jul 2019 15:45:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C886218A6 for ; Wed, 3 Jul 2019 15:45:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562168756; bh=pm5rTouD6xHz++5CAMKe/cfXETNu2i0/sl/YoyPzmz8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=C9nRA7LqK1VGV+YGvZvJdlK4wGwSOly5Ij2Jz4e9xG6svCT73UqBJBWw2FbkrChOO yY0o0Eex0jUpTUZk/uk/K//mhRhPYkZ/rOjgU+9OhaTlyn+BLAjAUDfU7Q7REqBJUL DDHeI8MKa/ap7L/+cHFDBFY6tLpVyk50M28OLKaU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726976AbfGCPpz (ORCPT ); Wed, 3 Jul 2019 11:45:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:49952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725847AbfGCPpy (ORCPT ); Wed, 3 Jul 2019 11:45:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 33FEB218B8; Wed, 3 Jul 2019 15:45:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562168753; bh=pm5rTouD6xHz++5CAMKe/cfXETNu2i0/sl/YoyPzmz8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=soBEtjfJ/l3Z4chuNxK1t5vLtLgUoRPkRzzUwzsQAE+LKmhhknDyaTvtC/b07t0rN EnWLpr+7MmQoFtaIKhmT0LztTb+CzAoIatUXwvXZmCTyGjYF73jmqFr/OG19QADdce WemDWe3+VbHrZySKD1wcjKvSo47OyF834+sOgSpQ= Date: Wed, 3 Jul 2019 17:45:51 +0200 From: Greg Kroah-Hartman To: Alexander Shishkin Cc: linux-kernel@vger.kernel.org, Shaokun Zhang , Andy Shevchenko Subject: Re: [GIT PULL 1/9] intel_th: msu: Fix unused variable warning on arm64 platform Message-ID: <20190703154551.GA19371@kroah.com> References: <20190627125152.54905-1-alexander.shishkin@linux.intel.com> <20190627125152.54905-2-alexander.shishkin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190627125152.54905-2-alexander.shishkin@linux.intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 27, 2019 at 03:51:44PM +0300, Alexander Shishkin wrote: > From: Shaokun Zhang > > Commit ba39bd8306057 ("intel_th: msu: Switch over to scatterlist") > introduced the following warnings on non-x86 architectures, as a result > of reordering the multi mode buffer allocation sequence: > > > drivers/hwtracing/intel_th/msu.c: In function ‘msc_buffer_win_alloc’: > > drivers/hwtracing/intel_th/msu.c:783:21: warning: unused variable ‘i’ > > [-Wunused-variable] > > int ret = -ENOMEM, i; > > ^ > > drivers/hwtracing/intel_th/msu.c: In function ‘msc_buffer_win_free’: > > drivers/hwtracing/intel_th/msu.c:863:6: warning: unused variable ‘i’ > > [-Wunused-variable] > > int i; > > ^ > > Fix this compiler warning by factoring out set_memory sequences and making > them x86-only. > > Suggested-by: Alexander Shishkin > Signed-off-by: Shaokun Zhang > Fixes: ba39bd8306057 ("intel_th: msu: Switch over to scatterlist") > Reviewed-by: Andy Shevchenko > Signed-off-by: Alexander Shishkin > --- > drivers/hwtracing/intel_th/msu.c | 40 +++++++++++++++++++++----------- > 1 file changed, 27 insertions(+), 13 deletions(-) Does not apply to my tree :(