From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Shaokun Zhang <zhangshaokun@hisilicon.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [GIT PULL 1/9] intel_th: msu: Fix unused variable warning on arm64 platform
Date: Wed, 3 Jul 2019 17:58:49 +0200 [thread overview]
Message-ID: <20190703155849.GA19567@kroah.com> (raw)
In-Reply-To: <87muhvt8pu.fsf@ashishki-desk.ger.corp.intel.com>
On Wed, Jul 03, 2019 at 06:54:05PM +0300, Alexander Shishkin wrote:
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
>
> > On Thu, Jun 27, 2019 at 03:51:44PM +0300, Alexander Shishkin wrote:
> >> From: Shaokun Zhang <zhangshaokun@hisilicon.com>
> >>
> >> Commit ba39bd8306057 ("intel_th: msu: Switch over to scatterlist")
> >> introduced the following warnings on non-x86 architectures, as a result
> >> of reordering the multi mode buffer allocation sequence:
> >>
> >> > drivers/hwtracing/intel_th/msu.c: In function ‘msc_buffer_win_alloc’:
> >> > drivers/hwtracing/intel_th/msu.c:783:21: warning: unused variable ‘i’
> >> > [-Wunused-variable]
> >> > int ret = -ENOMEM, i;
> >> > ^
> >> > drivers/hwtracing/intel_th/msu.c: In function ‘msc_buffer_win_free’:
> >> > drivers/hwtracing/intel_th/msu.c:863:6: warning: unused variable ‘i’
> >> > [-Wunused-variable]
> >> > int i;
> >> > ^
> >>
> >> Fix this compiler warning by factoring out set_memory sequences and making
> >> them x86-only.
> >>
> >> Suggested-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> >> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> >> Fixes: ba39bd8306057 ("intel_th: msu: Switch over to scatterlist")
> >> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> >> ---
> >> drivers/hwtracing/intel_th/msu.c | 40 +++++++++++++++++++++-----------
> >> 1 file changed, 27 insertions(+), 13 deletions(-)
> >
> > Does not apply to my tree :(
>
> It's the same one as the one in the fixes series. I just put it here for
> completeness.
to be extra sure it was really applied? that's funny...
next prev parent reply other threads:[~2019-07-03 15:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 12:51 [GIT PULL 0/9] intel_th: Updates for v5.3 Alexander Shishkin
2019-06-27 12:51 ` [GIT PULL 1/9] intel_th: msu: Fix unused variable warning on arm64 platform Alexander Shishkin
2019-07-03 15:45 ` Greg Kroah-Hartman
2019-07-03 15:45 ` Greg Kroah-Hartman
2019-07-03 15:54 ` Alexander Shishkin
2019-07-03 15:58 ` Greg Kroah-Hartman [this message]
2019-07-03 16:03 ` Alexander Shishkin
2019-06-27 12:51 ` [GIT PULL 2/9] intel_th: msu: Support multipage blocks Alexander Shishkin
2019-06-27 12:51 ` [GIT PULL 3/9] intel_th: msu: Split sgt array and pointer in multiwindow mode Alexander Shishkin
2019-06-27 12:51 ` [GIT PULL 4/9] intel_th: msu: Start read iterator from a non-empty window Alexander Shishkin
2019-06-27 12:51 ` [GIT PULL 5/9] intel_th: msu: Introduce buffer driver interface Alexander Shishkin
2019-07-03 15:55 ` Greg Kroah-Hartman
2019-07-03 16:33 ` Alexander Shishkin
2019-07-03 16:49 ` Greg Kroah-Hartman
2019-07-05 15:08 ` Alexander Shishkin
2019-06-27 12:51 ` [GIT PULL 6/9] intel_th: msu: Prevent freeing buffers while locked windows exist Alexander Shishkin
2019-06-27 12:51 ` [GIT PULL 7/9] intel_th: msu: Get rid of the window size limit Alexander Shishkin
2019-06-27 12:51 ` [GIT PULL 8/9] intel_th: msu-sink: An example msu buffer driver Alexander Shishkin
2019-07-03 15:56 ` Greg Kroah-Hartman
2019-06-27 12:51 ` [GIT PULL 9/9] intel_th: msu: Preserve pre-existing buffer configuration Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703155849.GA19567@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox