From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3FD2C0650E for ; Wed, 3 Jul 2019 17:43:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0FF721881 for ; Wed, 3 Jul 2019 17:43:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="j7C2OoIU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727013AbfGCRno (ORCPT ); Wed, 3 Jul 2019 13:43:44 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:45234 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726762AbfGCRnn (ORCPT ); Wed, 3 Jul 2019 13:43:43 -0400 Received: by mail-qt1-f196.google.com with SMTP id j19so4643699qtr.12 for ; Wed, 03 Jul 2019 10:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3R+cKk5Bmbmyzc5dQ/tTgoBX/k8q0Z5+azXiai77pjc=; b=j7C2OoIUgJZa7qnNyv2k/ythC2rLCDPyTyyuMZ7CDUqmdsX6uya0A5WKIiPniaK1rY LaehkAlLmDgC+BrBaOr7ae8FFyYYSiyJe3SXxSgCXXtUfJzoOfPly2uNzqhWjmjKiCBY AFanQHhW+HlDdjs4oNpawP5AJLVf5TlbUS8N2Pw9pg6UnSX97Ghic/QUX5IzUehfA/Qt aBnhgeAu5dnCxTmytLWsm9VFbftOmElIRDXX7niiSc4OzlGT8pp5MoFdJa9TUijmEqKT eJYQ4M/oSFEa+Cp5jzbh64MGl+uP3VADUtzOmLhADMoaea0Ge9GBVT0S4laHS7axJLSK MhUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3R+cKk5Bmbmyzc5dQ/tTgoBX/k8q0Z5+azXiai77pjc=; b=k8FyhGnux4URC1RIEOpebt8oH6wH7k5MfTHAWDIM+qu5fjppXQwpwI2yVpqf5nMoCD hMwNjJCRCLUQlYN3fy9uknx0/9QJ7Gd1T8KyMspNZ1MDT8Y6pRC7bq+mZjnGrFYMGuUK 5wWYvUU9GL0C6cYyyG2DdN+xxifuaFI87DJ0uvwn9MrEtkZLi9WtrAv38bMhwrDg5uo2 EiLntQ6meIb+yKvzmLnDDv5WC3tIiZqSSanWSLDsYFc89vGHjpniig9QM5QUhmSEoxW4 qvqbANxBp+EziPF98Io1LYbl0GlUheDBF5wFlNxY9w5bFBA6qDnH3EkQF+iTaLu/jG0d 9nhQ== X-Gm-Message-State: APjAAAV2KPDwFC9ibco81ceLdL9/GRgD97T7Qg6AHI111XHkvg/96fev 2YzMiJon2c01t87lso5pBZ7VdA== X-Google-Smtp-Source: APXvYqynKl5gRRZpXN6Qt0luanwwol4WD/SOZhlMZjF1iSxGoH6ma5AkdbLOxCscs3327MF8mOJBZw== X-Received: by 2002:aed:254c:: with SMTP id w12mr32978990qtc.127.1562175822996; Wed, 03 Jul 2019 10:43:42 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id t67sm1206056qkf.34.2019.07.03.10.43.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Jul 2019 10:43:42 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hijID-0003sm-RD; Wed, 03 Jul 2019 14:43:41 -0300 Date: Wed, 3 Jul 2019 14:43:41 -0300 From: Jason Gunthorpe To: Fuqian Huang Cc: Faisal Latif , Shiraz Saleem , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 09/35] infiniband: Use kmemdup rather than duplicating its implementation Message-ID: <20190703174341.GA14899@ziepe.ca> References: <20190703162742.32276-1-huangfq.daxian@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190703162742.32276-1-huangfq.daxian@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 04, 2019 at 12:27:42AM +0800, Fuqian Huang wrote: > kmemdup is introduced to duplicate a region of memory in a neat way. > Rather than kmalloc/kzalloc + memcpy, which the programmer needs to > write the size twice (sometimes lead to mistakes), kmemdup improves > readability, leads to smaller code and also reduce the chances of mistakes. > Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy. > > Signed-off-by: Fuqian Huang > --- > Changes in v2: > - Fix a typo in commit message (memset -> memcpy) > > drivers/infiniband/hw/i40iw/i40iw_cm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to rdma for-next Thanks, Jason